feat: show Java version warning in problems for pom.xml

Author: FluoriteCafe-work

jdtls.ext/com.microsoft.jdtls.ext.core/src/com/microsoft/jdtls/ext/core/model/PackageNode.java

@@ -88,6 +88,8 @@ public class PackageNode {
 
     private static final String MAX_SOURCE_VERSION = "MaxSourceVersion";
 
+    private static final String POM_PATH = "PomPath";
+
     /**
      * The name of the PackageNode.
      */
@@ -181,6 +183,10 @@ public static PackageNode createNodeForProject(IJavaElement javaElement) {
             int jdkLevel = (int) (CompilerOptions.versionToJdkLevel(sourceVersion, true) >>> 16);
             int majorVersion = Math.max(0, jdkLevel - ClassFileConstants.MAJOR_VERSION_0);
             projectNode.setMetaDataValue(MAX_SOURCE_VERSION, majorVersion);
+            IFile existingPom = proj.getFile("pom.xml");
+            if (existingPom.exists()) {
+                projectNode.setMetaDataValue(POM_PATH, existingPom.getLocation().toOSString());
+            }
         } catch (CoreException e) {
             // do nothing
         }

src/extension.ts

@@ -2,8 +2,10 @@
 // Licensed under the MIT license.
 
 import * as path from "path";
-import { commands, Diagnostic, Extension, ExtensionContext, extensions, languages,
-    Range, tasks, TextDocument, TextEditor, Uri, window, workspace } from "vscode";
+import {
+    commands, Diagnostic, Extension, ExtensionContext, extensions, languages,
+    Range, tasks, TextDocument, TextEditor, Uri, window, workspace
+} from "vscode";
 import { dispose as disposeTelemetryWrapper, initializeFromJsonFile, instrumentOperation, instrumentOperationAsVsCodeCommand, sendInfo } from "vscode-extension-telemetry-wrapper";
 import { Commands, contextManager } from "../extension.bundle";
 import { BuildTaskProvider } from "./tasks/build/buildTaskProvider";
@@ -20,6 +22,7 @@ import { DiagnosticProvider } from "./tasks/buildArtifact/migration/DiagnosticPr
 import { setContextForDeprecatedTasks, updateExportTaskType } from "./tasks/buildArtifact/migration/utils";
 import { CodeActionProvider } from "./tasks/buildArtifact/migration/CodeActionProvider";
 import { newJavaFile } from "./explorerCommands/new";
+import { promotionProvider } from "./promotionProvider";
 
 export async function activate(context: ExtensionContext): Promise<void> {
     contextManager.initialize(context);
@@ -44,6 +47,7 @@ async function activateExtension(_operationId: string, context: ExtensionContext
     context.subscriptions.push(DependencyExplorer.getInstance(context));
     context.subscriptions.push(contextManager);
     context.subscriptions.push(syncHandler);
+    context.subscriptions.push(promotionProvider);
     context.subscriptions.push(tasks.registerTaskProvider(DeprecatedExportJarTaskProvider.type, new DeprecatedExportJarTaskProvider()));
     context.subscriptions.push(tasks.registerTaskProvider(BuildArtifactTaskProvider.exportJarType, new BuildArtifactTaskProvider()));
     context.subscriptions.push(tasks.registerTaskProvider(BuildTaskProvider.type, new BuildTaskProvider()));

src/promotionProvider.ts

@@ -2,7 +2,12 @@
 // Licensed under the MIT license.
 
 import {
-    commands, extensions, window,
+    commands, extensions, window, Disposable,
+    languages,
+    Diagnostic,
+    Range,
+    DiagnosticSeverity,
+    Uri
 } from "vscode";
 import * as semver from "semver";
 import type { INodeData } from "../extension.bundle";
@@ -23,23 +28,33 @@ const PACKAGES_TO_CHECK_FOR_EOL: Record<string, { name: string, supportedVersion
 };
 
 
-export class PromotionProvider {
+export class PromotionProvider implements Disposable {
     public static getInstance() {
-        if (!this._instance) {
-            this._instance = new PromotionProvider();
-        }
-
-        return this._instance;
+        return promotionProvider;
     }
 
-    private static _instance: PromotionProvider;
-
     private haveAlreadyPrompted = false;
+    private diagnostics = languages.createDiagnosticCollection('javaUpgrade')
+
+    public dispose() {
+        this.diagnostics.dispose();
+    }
 
     public checkJavaVersion(data: INodeData) {
         const javaVersion = data.metaData?.MaxSourceVersion;
         if (javaVersion && javaVersion < EARLIEST_JAVA_VERSION_NOT_TO_PROMPT) {
             this.triggerJavaVersionUpgrade(javaVersion);
+            const pomPath = data.metaData?.PomPath;
+            if (pomPath) {
+                this.diagnostics.set(Uri.file(pomPath), [
+                    new Diagnostic(
+                        // TODO: locate the actual version settings
+                        new Range(0, 0, 0, 0),
+                        `Old Java version: ${javaVersion}`,
+                        DiagnosticSeverity.Warning
+                    )
+                ]);
+            }
         }
     }
 
@@ -93,4 +108,6 @@ export class PromotionProvider {
             });
         }
     }
-}
+}
+
+export const promotionProvider = new PromotionProvider();