Use outdated property on review thread

Part of #8401

Author: alexr00

src/common/comment.ts

@@ -65,6 +65,7 @@ export interface IComment {
 	graphNodeId: string;
 	reactions?: Reaction[];
 	isResolved?: boolean;
+	isOutdated?: boolean;
 }
 
 const COPILOT_AUTHOR = {

src/github/pullRequestModel.ts

@@ -647,7 +647,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 		});
 
 		const { comments, databaseId } = data!.deletePullRequestReview.pullRequestReview;
-		const deletedReviewComments = comments.nodes.map(comment => parseGraphQLComment(comment, false, this.githubRepository));
+		const deletedReviewComments = comments.nodes.map(comment => parseGraphQLComment(comment, false, false, this.githubRepository));
 
 		// Update local state: remove all draft comments (and their threads if emptied) that belonged to the deleted review
 		const deletedCommentIds = new Set(deletedReviewComments.map(c => c.id));
@@ -822,7 +822,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 		}
 
 		const { comment } = data.addPullRequestReviewComment;
-		const newComment = parseGraphQLComment(comment, false, this.githubRepository);
+		const newComment = parseGraphQLComment(comment, false, false, this.githubRepository);
 
 		if (isSingleComment) {
 			newComment.isDraft = false;
@@ -1024,6 +1024,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 		const newComment = parseGraphQLComment(
 			data.updatePullRequestReviewComment.pullRequestReviewComment,
 			!!comment.isResolved,
+			!!comment.isOutdated,
 			this.githubRepository
 		);
 		if (threadWithComment) {
@@ -1401,7 +1402,7 @@ export class PullRequestModel extends IssueModel<PullRequest> implements IPullRe
 
 		this.setReviewThreadCacheFromRaw(raw);
 
-		this.comments = raw.map(node => node.comments.nodes.map(comment => parseGraphQLComment(comment, node.isResolved, this.githubRepository), remote))
+		this.comments = raw.map(node => node.comments.nodes.map(comment => parseGraphQLComment(comment, node.isResolved, node.isOutdated, this.githubRepository), remote))
 			.reduce((prev, curr) => prev.concat(curr), [])
 			.sort((a: IComment, b: IComment) => {
 				return a.createdAt > b.createdAt ? 1 : -1;

src/github/utils.ts

@@ -521,12 +521,12 @@ export function parseGraphQLReviewThread(thread: GraphQL.ReviewThread, githubRep
 		originalEndLine: thread.originalLine,
 		diffSide: thread.diffSide,
 		isOutdated: thread.isOutdated,
-		comments: thread.comments.nodes.map(comment => parseGraphQLComment(comment, thread.isResolved, githubRepository)),
+		comments: thread.comments.nodes.map(comment => parseGraphQLComment(comment, thread.isResolved, thread.isOutdated, githubRepository)),
 		subjectType: thread.subjectType ?? SubjectType.LINE
 	};
 }
 
-export function parseGraphQLComment(comment: GraphQL.ReviewComment, isResolved: boolean, githubRepository: GitHubRepository): IComment {
+export function parseGraphQLComment(comment: GraphQL.ReviewComment, isResolved: boolean, isOutdated: boolean, githubRepository: GitHubRepository): IComment {
 	const specialAuthor = COPILOT_ACCOUNTS[comment.author?.login ?? ''];
 	const c: IComment = {
 		id: comment.databaseId,
@@ -551,6 +551,7 @@ export function parseGraphQLComment(comment: GraphQL.ReviewComment, isResolved:
 		inReplyToId: comment.replyTo && comment.replyTo.databaseId,
 		reactions: parseGraphQLReaction(comment.reactionGroups),
 		isResolved,
+		isOutdated
 	};
 
 	const diffHunks = parseCommentDiffHunk(c);
@@ -573,7 +574,7 @@ export function parseGraphQlIssueComment(comment: GraphQL.IssueComment, githubRe
 		htmlUrl: comment.url,
 		graphNodeId: comment.id,
 		diffHunk: '',
-		reactions: parseGraphQLReaction(comment.reactionGroups),
+		reactions: parseGraphQLReaction(comment.reactionGroups)
 	};
 }
 
@@ -1030,7 +1031,7 @@ export function parseGraphQLReviewEvent(
 ): Common.ReviewEvent {
 	return {
 		event: Common.EventType.Reviewed,
-		comments: review.comments.nodes.map(comment => parseGraphQLComment(comment, false, githubRepository)).filter(c => !c.inReplyToId),
+		comments: review.comments.nodes.map(comment => parseGraphQLComment(comment, false, false, githubRepository)).filter(c => !c.inReplyToId),
 		submittedAt: review.submittedAt,
 		body: review.body,
 		bodyHTML: review.bodyHTML,

src/test/view/reviewCommentController.test.ts

@@ -205,6 +205,7 @@ describe('ReviewCommentController', function () {
 							createdAt: '',
 							htmlUrl: '',
 							graphNodeId: '',
+							isOutdated: false
 						}
 					],
 					subjectType: SubjectType.LINE

src/view/reviewManager.ts

@@ -976,7 +976,7 @@ export class ReviewManager extends Disposable {
 			this._reviewModel.localFileChanges = await this.getLocalChangeNodes(pr, contentChanges);
 			await Promise.all([pr.initializeReviewThreadCacheAndReviewComments(), pr.initializePullRequestFileViewState()]);
 			this._folderRepoManager.setFileViewedContext();
-			const outdatedComments = pr.comments.filter(comment => !comment.position);
+			const outdatedComments = pr.comments.filter(comment => comment.isOutdated || !comment.position);
 
 			const commitsGroup = groupBy(outdatedComments, comment => comment.originalCommitId!);
 			const obsoleteFileChanges: (GitFileChangeNode | RemoteFileChangeNode)[] = [];