Skip to content

Commit 1d8ee18

Browse files
committed
Clean up
1 parent 43de6d1 commit 1d8ee18

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

src/github/pullRequestOverview.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -680,10 +680,6 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
680680
return PullRequestReviewCommon.readyForReviewAndMergeCommand(this.getReviewContext(), context);
681681
}
682682

683-
private async convertToDraftCommand(): Promise<void> {
684-
return PullRequestReviewCommon.convertToDraftCommand(this.getReviewContext());
685-
}
686-
687683
private async checkoutDefaultBranch(message: IRequestMessage<string>): Promise<void> {
688684
return PullRequestReviewCommon.checkoutDefaultBranch(this.getReviewContext(), message);
689685
}

src/github/pullRequestReviewCommon.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import * as vscode from 'vscode';
88
import { FolderRepositoryManager } from './folderRepositoryManager';
99
import { IAccount, isITeam, ITeam, MergeMethod, PullRequestMergeability, reviewerId, ReviewState } from './interface';
1010
import { PullRequestModel } from './pullRequestModel';
11-
import { PullRequest, ReadyForReviewReply, ReviewType, SubmitReviewReply } from './views';
11+
import { ConvertToDraftReply, PullRequest, ReadyForReviewReply, ReviewType, SubmitReviewReply } from './views';
1212
import { DEFAULT_DELETION_METHOD, PR_SETTINGS_NAMESPACE, SELECT_LOCAL_BRANCH, SELECT_REMOTE } from '../common/settingKeys';
1313
import { ReviewEvent, TimelineEvent } from '../common/timelineEvent';
1414
import { Schemes } from '../common/uri';
@@ -231,7 +231,7 @@ export namespace PullRequestReviewCommon {
231231

232232
export async function setConvertToDraft(ctx: ReviewContext, _message: IRequestMessage<{}>): Promise<void> {
233233
try {
234-
const result = await ctx.item.convertToDraft();
234+
const result: ConvertToDraftReply = await ctx.item.convertToDraft();
235235
ctx.replyMessage(_message, result);
236236
} catch (e) {
237237
vscode.window.showErrorMessage(vscode.l10n.t('Unable to convert pull request to draft. {0}', formatError(e)));

webviews/common/context.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import { getMessageHandler, MessageHandler } from './message';
99
import { CloseResult, OpenCommitChangesArgs } from '../../common/views';
1010
import { IComment } from '../../src/common/comment';
1111
import { EventType, ReviewEvent, SessionLinkInfo, TimelineEvent } from '../../src/common/timelineEvent';
12-
import { ConvertToDraft, IProjectItem, MergeMethod, ReadyForReview } from '../../src/github/interface';
13-
import { CancelCodingAgentReply, ChangeAssigneesReply, DeleteReviewResult, MergeArguments, MergeResult, ProjectItemsReply, PullRequest, ReadyForReviewReply, SubmitReviewReply } from '../../src/github/views';
12+
import { IProjectItem, MergeMethod, ReadyForReview } from '../../src/github/interface';
13+
import { CancelCodingAgentReply, ChangeAssigneesReply, ConvertToDraftReply, DeleteReviewResult, MergeArguments, MergeResult, ProjectItemsReply, PullRequest, ReadyForReviewReply, SubmitReviewReply } from '../../src/github/views';
1414

1515
export class PRContext {
1616
constructor(
@@ -91,7 +91,7 @@ export class PRContext {
9191

9292
public readyForReviewAndMerge = (args: { mergeMethod: MergeMethod }): Promise<ReadyForReview> => this.postMessage({ command: 'pr.readyForReviewAndMerge', args });
9393

94-
public convertToDraft = (): Promise<ConvertToDraft> => this.postMessage({ command: 'pr.convertToDraft' });
94+
public convertToDraft = (): Promise<ConvertToDraftReply> => this.postMessage({ command: 'pr.convertToDraft' });
9595

9696
public addReviewers = () => this.postMessage({ command: 'pr.change-reviewers' });
9797
public changeProjects = (): Promise<ProjectItemsReply> => this.postMessage({ command: 'pr.change-projects' });

0 commit comments

Comments
 (0)