Skip to content

Commit 2ac1bf2

Browse files
Copilotalexr00
andcommitted
Use button element instead of anchor and improve keyboard handling
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>
1 parent 4b9147b commit 2ac1bf2

File tree

1 file changed

+2
-2
lines changed
  • webviews/createPullRequestViewNew

1 file changed

+2
-2
lines changed

webviews/createPullRequestViewNew/app.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ export function main() {
179179
event.preventDefault();
180180
ctx.postMessage({ command: 'pr.openDescriptionSettings' });
181181
}
182-
} else {
182+
} else if (event.type === 'click') {
183183
ctx.postMessage({ command: 'pr.openDescriptionSettings' });
184184
}
185185
}
@@ -339,7 +339,7 @@ export function main() {
339339

340340
<div className='group-description-header'>
341341
<label htmlFor='description' className='input-title'>Description</label>
342-
<a title='Open pull request description settings' className='description-settings-action icon-button' onClick={openDescriptionSettings} onKeyDown={openDescriptionSettings} tabIndex={0}>{settingsIcon}</a>
342+
<button type='button' title='Open pull request description settings' className='description-settings-action icon-button' onClick={openDescriptionSettings} onKeyDown={openDescriptionSettings} tabIndex={0}>{settingsIcon}</button>
343343
</div>
344344
<div className='group-description'>
345345
<textarea

0 commit comments

Comments
 (0)