Projects picker doesn't refresh after signing in with more token scopes (#6936)

Fixes #6928

Author: alexr00

src/github/issueOverview.ts

@@ -132,6 +132,10 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
 				}
 			}));
 
+		this._register(folderRepositoryManager.credentialStore.onDidUpgradeSession(() => {
+			this.updateItem(this._item);
+		}));
+
 		this._register(this._panel.onDidChangeViewState(e => this.onDidChangeViewState(e)));
 		this.pollForUpdates();
 		this._register(vscode.workspace.onDidChangeConfiguration(e => {
@@ -208,7 +212,7 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
 		return context;
 	}
 
-	public async updateIssue(issueModel: IssueModel): Promise<void> {
+	protected async updateItem(issueModel: TItem): Promise<void> {
 		try {
 			const [
 				issue,
@@ -250,15 +254,15 @@ export class IssueOverviewPanel<TItem extends IssueModel = IssueModel> extends W
 		}
 	}
 
-	public async update(foldersManager: FolderRepositoryManager, issueModel: IssueModel): Promise<void> {
+	public async update(foldersManager: FolderRepositoryManager, issueModel: TItem): Promise<void> {
 		this._folderRepositoryManager = foldersManager;
 		this._postMessage({
 			command: 'set-scroll',
 			scrollPosition: this._scrollPosition,
 		});
 
 		this._panel.webview.html = this.getHtmlForWebview();
-		return this.updateIssue(issueModel);
+		return this.updateItem(issueModel);
 	}
 
 	protected override async _onDidReceiveMessage(message: IRequestMessage<any>) {

src/github/pullRequestOverview.ts

@@ -118,9 +118,6 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 				state: GithubItemStateEnum.Merged,
 			});
 		}));
-		this._register(folderRepositoryManager.credentialStore.onDidUpgradeSession(() => {
-			this.updatePullRequest(this._item);
-		}));
 
 		this._register(vscode.commands.registerCommand('review.approveDescription', (e) => this.approvePullRequestCommand(e)));
 		this._register(vscode.commands.registerCommand('review.commentDescription', (e) => this.submitReviewCommand(e)));
@@ -186,7 +183,7 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 		return super.continueOnGitHub() && isCrossRepository;
 	}
 
-	private async updatePullRequest(pullRequestModel: PullRequestModel): Promise<void> {
+	protected override async updateItem(pullRequestModel: PullRequestModel): Promise<void> {
 		try {
 			const [
 				pullRequest,
@@ -308,7 +305,7 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
 			this._panel.webview.html = this.getHtmlForWebview();
 		}
 
-		return vscode.window.withProgress({ location: { viewId: 'pr:github' } }, () => this.updatePullRequest(pullRequestModel));
+		return vscode.window.withProgress({ location: { viewId: 'pr:github' } }, () => this.updateItem(pullRequestModel));
 	}
 
 	protected override async _onDidReceiveMessage(message: IRequestMessage<any>) {