Skip to content

Commit 5534638

Browse files
committed
Remove some bad eslint comments
1 parent 3280a4a commit 5534638

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

eslint.config.mjs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import * as importPlugin from 'eslint-plugin-import';
99
import { defineConfig } from 'eslint/config';
1010
import rulesdir from './build/eslint-rules/index.js';
1111
import tseslint from 'typescript-eslint';
12-
import globals from "globals";
12+
import globals from 'globals';
1313

1414
export default defineConfig([
1515
// Global ignore patterns

src/github/createPRViewProvider.ts

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -629,8 +629,7 @@ export class CreatePullRequestViewProvider extends BaseCreatePullRequestViewProv
629629
return undefined;
630630
}
631631

632-
// eslint-disable-next-line @typescript-eslint/await-thenable
633-
const [pr, compareBranch] = await Promise.all([await this._folderRepositoryManager.resolvePullRequest(existingPR.owner, existingPR.repositoryName, existingPR.prNumber), this._folderRepositoryManager.repository.getBranch(this.model.compareBranch)]);
632+
const [pr, compareBranch] = await Promise.all([this._folderRepositoryManager.resolvePullRequest(existingPR.owner, existingPR.repositoryName, existingPR.prNumber), this._folderRepositoryManager.repository.getBranch(this.model.compareBranch)]);
634633
return (pr?.head?.sha === compareBranch.commit) ? vscode.l10n.t('A pull request already exists for this branch.') : undefined;
635634
}
636635

@@ -705,8 +704,7 @@ export class CreatePullRequestViewProvider extends BaseCreatePullRequestViewProv
705704
const [totalCommits, lastCommit, pullRequestTemplate] = await Promise.all([
706705
this.getTotalGitHubCommits(compareBranch, baseBranch),
707706
name ? titleAndBodyFrom(promiseWithTimeout(this._folderRepositoryManager.getTipCommitMessage(name), 5000)) : undefined,
708-
// eslint-disable-next-line @typescript-eslint/await-thenable
709-
descrptionSource === 'template' ? await this.getPullRequestTemplate() : undefined
707+
descrptionSource === 'template' ? this.getPullRequestTemplate() : undefined
710708
]);
711709
const totalNonMergeCommits = totalCommits?.filter(commit => commit.parents.length < 2);
712710

0 commit comments

Comments
 (0)