Skip to content

Commit 709f238

Browse files
committed
Address feedback
1 parent 8809568 commit 709f238

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

webviews/createPullRequestViewNew/app.tsx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ export function main() {
192192
<div className='group-branches'>
193193
<div className='input-label base'>
194194
<div className="deco">
195-
<span title='Base branch' aria-hidden='true'>{prBaseIcon} BASE</span>
195+
<span title='Base branch' aria-hidden='true'>{prBaseIcon} Base</span>
196196
</div>
197197
<ChooseRemoteAndBranch onClick={ctx.changeBaseRemoteAndBranch}
198198
defaultRemote={params.baseRemote}
@@ -205,7 +205,7 @@ export function main() {
205205

206206
<div className='input-label merge'>
207207
<div className="deco">
208-
<span title='Merge branch' aria-hidden='true'>{prMergeIcon} {params.actionDetail ? params.actionDetail : 'MERGE'}</span>
208+
<span title='Merge branch' aria-hidden='true'>{prMergeIcon} {params.actionDetail ? params.actionDetail : 'Merge'}</span>
209209
</div>
210210
{ctx.createParams.canModifyBranches ?
211211
<ChooseRemoteAndBranch onClick={ctx.changeMergeRemoteAndBranch}
@@ -220,7 +220,7 @@ export function main() {
220220
</div>
221221
</div>
222222

223-
<span className='input-title'>TITLE</span>
223+
<label htmlFor='title' className='input-title'>Title</label>
224224
<div className='group-title'>
225225
<input
226226
id='title'
@@ -232,7 +232,6 @@ export function main() {
232232
aria-invalid={!!params.showTitleValidationError}
233233
aria-describedby={params.showTitleValidationError ? 'title-error' : ''}
234234
placeholder='Title'
235-
aria-label='Title'
236235
title='Required'
237236
required
238237
onChange={(e) => updateTitle(e.currentTarget.value)}
@@ -326,13 +325,12 @@ export function main() {
326325
: null}
327326
</div>
328327

329-
<span className='input-title'>DESCRIPTION</span>
328+
<label htmlFor='description' className='input-title'>Description</label>
330329
<div className='group-description'>
331330
<textarea
332331
id='description'
333332
name='description'
334333
placeholder='Description'
335-
aria-label='Description'
336334
value={params.pendingDescription}
337335
onChange={(e) => ctx.updateState({ pendingDescription: e.currentTarget.value })}
338336
onKeyDown={(e) => onKeyDown(false, e)}
@@ -373,13 +371,15 @@ export function main() {
373371
);
374372
}
375373

376-
export function Root({ children }) {
374+
interface RootProps { children: (params: CreateParamsNew) => JSX.Element }
375+
376+
export function Root({ children }: RootProps): JSX.Element {
377377
const ctx = useContext(PullRequestContextNew);
378378
const [pr, setPR] = useState<any>(ctx.createParams);
379379
useEffect(() => {
380380
ctx.onchange = setPR;
381381
setPR(ctx.createParams);
382382
}, []);
383383
ctx.postMessage({ command: 'ready' });
384-
return children(pr);
384+
return <>{children(pr)}</>;
385385
}

webviews/createPullRequestViewNew/index.css

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ button.input-box {
7373
display: flex;
7474
align-items: center;
7575
font-size: 11px;
76+
text-transform: uppercase;
7677
margin-bottom: 14px;
7778
}
7879

@@ -89,6 +90,7 @@ button.input-box {
8990
display: block;
9091
font-size: 11px;
9192
margin-bottom: 4px;
93+
text-transform: uppercase;
9294
}
9395

9496
#title {

0 commit comments

Comments
 (0)