Merge branch 'main' into copilot/fix-7280

Author: alexr00

.eslintrc.base.json

@@ -66,6 +66,13 @@
 		"no-useless-return": "off",
 		"no-var": "error",
 		"no-with": "error",
+		"no-restricted-syntax": [
+			"error",
+			{
+				"selector": "BinaryExpression[operator='in']",
+				"message": "Avoid using the 'in' operator for type checks."
+			}
+		],
 		"object-shorthand": "off",
 		"one-var": "off", // TODO@eamodio revisit
 		// "one-var": ["error", "never"],
@@ -230,7 +237,7 @@
 		"@typescript-eslint/no-unsafe-member-access": "off", // TODO@eamodio revisit
 		"@typescript-eslint/no-unsafe-return": "off", // TODO@eamodio revisit
 		"@typescript-eslint/no-unused-expressions": ["warn", { "allowShortCircuit": true }],
-		"@typescript-eslint/no-unused-vars": ["warn", { "argsIgnorePattern": "^_" }],
+		"@typescript-eslint/no-unused-vars": ["error", { "argsIgnorePattern": "^_" }],
 		// "@typescript-eslint/no-unused-vars": [
 		// 	"warn",
 		// 	{

.eslintrc.js

@@ -0,0 +1,36 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+'use strict';
+
+const RULES_DIR = require('eslint-plugin-rulesdir');
+RULES_DIR.RULES_DIR = './build/eslint-rules';
+
+module.exports = {
+	extends: ['.eslintrc.base.json'],
+	env: {
+		browser: true,
+		node: true
+	},
+	parserOptions: {
+		project: 'tsconfig.eslint.json'
+	},
+	plugins: ['rulesdir'],
+	overrides: [
+		{
+			files: ['webviews/**/*.ts', 'webviews/**/*.tsx'],
+			rules: {
+				'rulesdir/public-methods-well-defined-types': 'error'
+			}
+		},
+		{
+			files: ['**/*.ts', '**/*.tsx'],
+			rules: {
+				'rulesdir/no-any-except-union-method-signature': 'error',
+				'rulesdir/no-pr-in-user-strings': 'error'
+			}
+		}
+	]
+};

.eslintrc.json

@@ -13,9 +13,19 @@
 - **Webviews**: Place webview code in the `webviews/` directory. Use the shared `common/` code where possible.
 - **Commands**: Register new commands in `package.json` and implement them in `src/commands.ts` or a relevant module.
 - **Logging**: Use the `Logger` utility for all logging purposes. Don't use console.log or similar methods directly.
+- **Test Running**: Use tools over tasks over scripts to run tests.
+
+## Specific Feature Practices
+- **Commands**: When adding a new command, consider whether it should be available in the command palette, context menus, or both. Add the appropriate menu entries in `package.json` to ensure the command is properly included, or excluded (command palette), from menus.
 
 ## Pull Request Guidelines
 - Never touch the yarn.lock file.
+- Run `yarn run lint` and also `npm run hygiene` and fix any errors or warnings before committing.
+
+## Testing
+- Use `describe` and `it` blocks from Mocha for structuring tests.
+- Tests MUST run product code.
+- Tests should be placed near the code they are testing, in a `test` folder. Name test fies with a `.test.ts` suffix.
 
 ---
 _Last updated: 2025-06-20_

.github/copilot-instructions.md

@@ -2,3 +2,4 @@
 . "$(dirname -- "$0")/_/husky.sh"
 
 npm run hygiene
+npm run lint

.husky/pre-commit

@@ -0,0 +1,29 @@
+
+import { defineConfig } from "@vscode/test-cli";
+
+/**
+ * @param {string} label
+ */
+function generateConfig(label) {
+  /** @type {import('@vscode/test-cli').TestConfiguration} */
+  let config = {
+    label,
+    files: ["dist/**/*.test.js"],
+    version: "insiders",
+    srcDir: "src",
+    launchArgs: [
+      "--enable-proposed-api",
+      "--disable-extension=GitHub.vscode-pull-request-github-insiders",
+    ],
+    // env,
+    mocha: {
+      ui: "bdd",
+      color: true,
+      timeout: 25000
+    },
+  };
+
+  return config;
+}
+
+export default defineConfig(generateConfig("Local Tests"));

.vscode-test.mjs

@@ -1,6 +1,7 @@
 {
 	"recommendations": [
 		"dbaeumer.vscode-eslint",
-		"amodio.tsl-problem-matcher"
+		"amodio.tsl-problem-matcher",
+		"ms-vscode.extension-test-runner"
 	]
 }

.vscode/extensions.json

@@ -102,12 +102,11 @@
 			"type": "node",
 			"request": "launch",
 			"name": "Attach Web Test",
-			"program": "${workspaceFolder}/node_modules/vscode-test-web/out/index.js",
+			"program": "${workspaceFolder}/node_modules/@vscode/test-web/out/server/index.js",
 			"args": [
 				"--extensionTestsPath=dist/browser/test/index.js",
 				"--extensionDevelopmentPath=.",
 				"--browserType=chromium",
-				"--attach=9229"
 			],
 			"cascadeTerminateToConfigurations": [
 				"Launch Web Test"

.vscode/launch.json

@@ -4,6 +4,14 @@
 		".eslintrc.json": "jsonc",
 		".eslintrc.*.json": "jsonc"
 	},
+	"json.schemas": [
+		{
+			"fileMatch": [
+				"**/.eslintrc.*.json"
+			],
+			"url": "https://json.schemastore.org/eslintrc"
+		}
+	],
 	"files.trimTrailingWhitespace": true,
 	"gitlens.advanced.blame.customArguments": ["--ignore-revs-file", ".gitignore-revs"]
 }

.vscode/settings.json

@@ -12,6 +12,7 @@ node_modules/**
 scripts/**
 src/**
 webviews/**
+**/test/**
 .eslintcache*
 .eslintignore
 .eslintrc*