Skip to content

Commit cf03de5

Browse files
committed
Fix auto merge not updating in create view
Fixes #8195
1 parent f9104f4 commit cf03de5

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

webviews/common/createContextNew.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,8 @@ export class CreatePRContextNew {
110110
currentRemote,
111111
currentBranch
112112
};
113+
const startingBaseOwner = this.createParams.baseRemote?.owner;
114+
const startingBaseRepo = this.createParams.baseRemote?.repositoryName;
113115
const response: ChooseBaseRemoteAndBranchResult = await this.postMessage({
114116
command: 'pr.changeBaseRemoteAndBranch',
115117
args
@@ -120,14 +122,16 @@ export class CreatePRContextNew {
120122
baseBranch: response.baseBranch,
121123
createError: ''
122124
};
123-
if ((this.createParams.baseRemote?.owner !== response.baseRemote.owner) || (this.createParams.baseRemote.repositoryName !== response.baseRemote.repositoryName)) {
125+
if ((startingBaseOwner !== response.baseRemote.owner) || (startingBaseRepo !== response.baseRemote.repositoryName)) {
124126
updateValues.defaultMergeMethod = response.defaultMergeMethod;
125127
updateValues.allowAutoMerge = response.allowAutoMerge;
126128
updateValues.mergeMethodsAvailability = response.mergeMethodsAvailability;
127129
updateValues.autoMergeDefault = response.autoMergeDefault;
128130
updateValues.baseHasMergeQueue = response.baseHasMergeQueue;
129131
if (!this.createParams.allowAutoMerge && updateValues.allowAutoMerge) {
130132
updateValues.autoMerge = this.createParams.isDraft ? false : updateValues.autoMergeDefault;
133+
} else if (this.createParams.allowAutoMerge && !updateValues.allowAutoMerge) {
134+
updateValues.autoMerge = false;
131135
}
132136
updateValues.defaultTitle = response.defaultTitle;
133137
if ((this.createParams.pendingTitle === undefined) || (this.createParams.pendingTitle === this.createParams.defaultTitle)) {

0 commit comments

Comments
 (0)