Skip to content

Commit d7b7d3b

Browse files
committed
Use a type
1 parent 9465868 commit d7b7d3b

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

src/github/pullRequestOverview.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ import { isCopilotOnMyBehalf, PullRequestModel } from './pullRequestModel';
2525
import { PullRequestReviewCommon, ReviewContext } from './pullRequestReviewCommon';
2626
import { branchPicks, pickEmail, reviewersQuickPick } from './quickPicks';
2727
import { parseReviewers } from './utils';
28-
import { CancelCodingAgentReply, DeleteReviewResult, MergeArguments, MergeResult, PullRequest, ReviewType } from './views';
28+
import { CancelCodingAgentReply, ChangeBaseReply, DeleteReviewResult, MergeArguments, MergeResult, PullRequest, ReviewType } from './views';
2929
import { IComment } from '../common/comment';
3030
import { COPILOT_SWE_AGENT, copilotEventToStatus, CopilotPRStatus, mostRecentCopilotEvent } from '../common/copilot';
3131
import { commands, contexts } from '../common/executeCommands';
@@ -830,7 +830,10 @@ export class PullRequestOverviewPanel extends IssueOverviewPanel<PullRequestMode
830830
if (selectedBranch) {
831831
try {
832832
await this._item.updateBaseBranch(selectedBranch);
833-
await this._replyMessage(message, { base: selectedBranch });
833+
const reply: ChangeBaseReply = {
834+
base: selectedBranch
835+
};
836+
await this._replyMessage(message, reply);
834837
} catch (e) {
835838
Logger.error(formatError(e), PullRequestOverviewPanel.ID);
836839
vscode.window.showErrorMessage(vscode.l10n.t('Changing base branch failed. {0}', formatError(e)));

src/github/views.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,4 +173,8 @@ export interface OverviewContext {
173173
export interface CodingAgentContext extends SessionLinkInfo {
174174
'preventDefaultContextMenuItems': true;
175175
[key: string]: boolean | string | number | undefined;
176+
}
177+
178+
export interface ChangeBaseReply {
179+
base: string;
176180
}

webviews/common/context.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import { CloseResult, OpenCommitChangesArgs } from '../../common/views';
1010
import { IComment } from '../../src/common/comment';
1111
import { EventType, ReviewEvent, SessionLinkInfo, TimelineEvent } from '../../src/common/timelineEvent';
1212
import { IProjectItem, MergeMethod, ReadyForReview } from '../../src/github/interface';
13-
import { CancelCodingAgentReply, ChangeAssigneesReply, DeleteReviewResult, MergeArguments, MergeResult, ProjectItemsReply, PullRequest, ReadyForReviewReply, SubmitReviewReply } from '../../src/github/views';
13+
import { CancelCodingAgentReply, ChangeAssigneesReply, ChangeBaseReply, DeleteReviewResult, MergeArguments, MergeResult, ProjectItemsReply, PullRequest, ReadyForReviewReply, SubmitReviewReply } from '../../src/github/views';
1414

1515
export class PRContext {
1616
constructor(
@@ -93,7 +93,7 @@ export class PRContext {
9393

9494
public addReviewers = () => this.postMessage({ command: 'pr.change-reviewers' });
9595
public changeBaseBranch = async () => {
96-
const result = await this.postMessage({ command: 'pr.change-base-branch' });
96+
const result: ChangeBaseReply = await this.postMessage({ command: 'pr.change-base-branch' });
9797
if (result?.base) {
9898
this.updatePR({ base: result.base });
9999
}

0 commit comments

Comments
 (0)