Address review feedback: add owner/repo, use scheme constant, listen for timeline changes

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

src/common/uri.ts

@@ -521,17 +521,21 @@ export function createPRNodeUri(
 }
 
 export interface CommitsNodeUriParams {
+	owner: string;
+	repo: string;
 	prNumber: number;
 	commitsCount: number;
 }
 
-export function createCommitsNodeUri(prNumber: number, commitsCount: number): vscode.Uri {
+export function createCommitsNodeUri(owner: string, repo: string, prNumber: number, commitsCount: number): vscode.Uri {
 	const params: CommitsNodeUriParams = {
+		owner,
+		repo,
 		prNumber,
 		commitsCount
 	};
 
-	return vscode.Uri.parse(`commitsnode:${prNumber}`).with({
+	return vscode.Uri.parse(`${Schemes.CommitsNode}:${owner}/${repo}/${prNumber}`).with({
 		scheme: Schemes.CommitsNode,
 		query: JSON.stringify(params)
 	});

src/view/commitsDecorationProvider.ts

@@ -5,7 +5,7 @@
 
 import * as vscode from 'vscode';
 import { TreeDecorationProvider } from './treeDecorationProviders';
-import { fromCommitsNodeUri, Schemes } from '../common/uri';
+import { createCommitsNodeUri, fromCommitsNodeUri, Schemes } from '../common/uri';
 import { FolderRepositoryManager } from '../github/folderRepositoryManager';
 import { PullRequestModel } from '../github/pullRequestModel';
 
@@ -15,9 +15,14 @@ export class CommitsDecorationProvider extends TreeDecorationProvider {
 		super();
 	}
 
-	registerPullRequestPropertyChangedListeners(_folderManager: FolderRepositoryManager, _model: PullRequestModel): vscode.Disposable {
-		// No need to listen for changes since commit count doesn't change dynamically
-		return { dispose: () => { } };
+	registerPullRequestPropertyChangedListeners(_folderManager: FolderRepositoryManager, model: PullRequestModel): vscode.Disposable {
+		return model.onDidChange(e => {
+			if (e.timeline) {
+				// Timeline changed, which may include new commits, so update the decoration
+				const uri = createCommitsNodeUri(model.remote.owner, model.remote.repositoryName, model.number, model.item.commits.length);
+				this._onDidChangeFileDecorations.fire(uri);
+			}
+		});
 	}
 
 	provideFileDecoration(

src/view/treeDecorationProviders.ts

@@ -11,7 +11,7 @@ import { PullRequestModel } from '../github/pullRequestModel';
 import { RepositoriesManager } from '../github/repositoriesManager';
 
 export abstract class TreeDecorationProvider extends Disposable implements vscode.FileDecorationProvider {
-	private _onDidChangeFileDecorations: vscode.EventEmitter<vscode.Uri | vscode.Uri[]> = this._register(new vscode.EventEmitter<
+	protected _onDidChangeFileDecorations: vscode.EventEmitter<vscode.Uri | vscode.Uri[]> = this._register(new vscode.EventEmitter<
 		vscode.Uri | vscode.Uri[]
 	>());
 	onDidChangeFileDecorations?: vscode.Event<vscode.Uri | vscode.Uri[] | undefined> | undefined = this._onDidChangeFileDecorations.event;

src/view/treeNodes/commitsCategoryNode.ts

@@ -27,7 +27,7 @@ export class CommitsNode extends TreeNode implements vscode.TreeItem {
 		this._pr = pr;
 		this._folderRepoManager = reposManager;
 		this.collapsibleState = vscode.TreeItemCollapsibleState.Collapsed;
-		this.resourceUri = createCommitsNodeUri(pr.number, pr.item.commits.length);
+		this.resourceUri = createCommitsNodeUri(pr.remote.owner, pr.remote.repositoryName, pr.number, pr.item.commits.length);
 
 		this.childrenDisposables = [];
 		this.childrenDisposables.push(this._pr.onDidChangeReviewThreads(() => {