Merge branch 'main' into copilot/fix-icons-misalignment

Author: alexr00

.vscodeignore

@@ -29,8 +29,7 @@ azure-pipeline.*
 yarn.lock
 **/*.map
 **/*.svg
-!**/output.svg
-!**/pr_webview.svg
+!**/git-pull-request_webview.svg
 **/*.ts
 *.vsix
 **/*.bak

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.120.1
+
+### Fixes
+
+- Extension cannot find git repo when VS Code didn't open the git root directory. https://github.com/microsoft/vscode-pull-request-github/issues/7964
+
 ## 0.120.0
 
 ### Changes

azure-pipeline.nightly.yml

@@ -3,7 +3,7 @@ trigger: none
 pr: none
 
 schedules:
-  - cron: '0 4 * * Mon-Thu'
+  - cron: '0 4 * * Mon-Fri'
     displayName: Nightly Release Schedule
     always: true
     branches:

build/filters.js

@@ -64,6 +64,7 @@ module.exports.copyrightFilter = [
 	'!tsconfig.json',
 	'!tsconfig.test.json',
 	'!tsconfig.webviews.json',
+	'!tsconfig.scripts.json',
 	'!tsfmt.json',
 	'!**/queries*.gql',
 	'!**/*.yml',

build/update-codicons.ts

@@ -0,0 +1,107 @@
+/*---------------------------------------------------------------------------------------------
+ *  Copyright (c) Microsoft Corporation. All rights reserved.
+ *  Licensed under the MIT License. See License.txt in the project root for license information.
+ *--------------------------------------------------------------------------------------------*/
+
+import * as fs from 'fs';
+import * as path from 'path';
+import * as https from 'https';
+
+const CODICONS_DIR = path.join(__dirname, '..', 'resources', 'icons', 'codicons');
+const BASE_URL = 'https://raw.githubusercontent.com/microsoft/vscode-codicons/refs/heads/mrleemurray/new-icons/src/icons';
+
+interface UpdateResult {
+	filename: string;
+	status: 'updated' | 'unchanged' | 'error';
+	error?: string;
+}
+
+function readLocalIconFilenames(): string[] {
+	return fs.readdirSync(CODICONS_DIR).filter(f => f.endsWith('.svg'));
+}
+
+function fetchRemoteIcon(filename: string): Promise<string> {
+	const url = `${BASE_URL}/${encodeURIComponent(filename)}`;
+	return new Promise((resolve, reject) => {
+		https.get(url, res => {
+			const { statusCode } = res;
+			if (statusCode !== 200) {
+				res.resume(); // drain
+				return reject(new Error(`Failed to fetch ${filename}: HTTP ${statusCode}`));
+			}
+			let data = '';
+			res.setEncoding('utf8');
+			res.on('data', chunk => { data += chunk; });
+			res.on('end', () => resolve(data));
+		}).on('error', reject);
+	});
+}
+
+async function updateIcon(filename: string): Promise<UpdateResult> {
+	const localPath = path.join(CODICONS_DIR, filename);
+	const oldContent = fs.readFileSync(localPath, 'utf8');
+	try {
+		const newContent = await fetchRemoteIcon(filename);
+		if (normalize(oldContent) === normalize(newContent)) {
+			return { filename, status: 'unchanged' };
+		}
+		fs.writeFileSync(localPath, newContent, 'utf8');
+		return { filename, status: 'updated' };
+	} catch (err: any) {
+		return { filename, status: 'error', error: err?.message ?? String(err) };
+	}
+}
+
+function normalize(svg: string): string {
+	return svg.replace(/\r\n?/g, '\n').trim();
+}
+
+async function main(): Promise<void> {
+	const icons = readLocalIconFilenames();
+	if (!icons.length) {
+		console.log('No codicon SVGs found to update.');
+		return;
+	}
+	console.log(`Updating ${icons.length} codicon(s) from upstream...`);
+
+	const concurrency = 8;
+	const queue = icons.slice();
+	const results: UpdateResult[] = [];
+
+	async function worker(): Promise<void> {
+		while (queue.length) {
+			const file = queue.shift();
+			if (!file) {
+				break;
+			}
+			const result = await updateIcon(file);
+			results.push(result);
+			if (result.status === 'updated') {
+				console.log(` ✔ ${file} updated`);
+			} else if (result.status === 'unchanged') {
+				console.log(` • ${file} unchanged`);
+			} else {
+				// allow-any-unicode-next-line
+				console.warn(` ✖ ${file} ${result.error}`);
+			}
+		}
+	}
+
+	const workers = Array.from({ length: Math.min(concurrency, icons.length) }, () => worker());
+	await Promise.all(workers);
+
+	const updated = results.filter(r => r.status === 'updated').length;
+	const unchanged = results.filter(r => r.status === 'unchanged').length;
+	const errored = results.filter(r => r.status === 'error').length;
+	console.log(`Done. Updated: ${updated}, Unchanged: ${unchanged}, Errors: ${errored}.`);
+	if (errored) {
+		process.exitCode = 1;
+	}
+}
+
+main().catch(err => {
+	console.error(err?.stack || err?.message || String(err));
+	process.exit(1);
+});
+
+export { }; // ensure this file is treated as a module

eslint.config.mjs

@@ -15,6 +15,7 @@ export default defineConfig([
 	// Global ignore patterns
 	{
 		ignores: [
+			'build',
 			'dist/**/*',
 			'out/**/*',
 			'src/@types/**/*.d.ts',

package.json

@@ -14,7 +14,7 @@
 		"activeComment",
 		"chatParticipantAdditions",
 		"chatParticipantPrivate",
-		"chatSessionsProvider@2",
+		"chatSessionsProvider@3",
 		"codiconDecoration",
 		"codeActionRanges",
 		"commentingRangeHint",
@@ -75,7 +75,7 @@
 				"name": "copilot",
 				"displayName": "GitHub Copilot coding agent",
 				"description": "Delegate tasks to the GitHub Copilot coding agent. The agent works asynchronously to implement changes, iterates via chat, and can create or update pull requests as needed.",
-				"when": "config.chat.agentSessionsViewLocation && config.chat.agentSessionsViewLocation != 'disabled'",
+				"when": "config.chat.agentSessionsViewLocation && config.chat.agentSessionsViewLocation != 'disabled' && config.github.copilot.chat.advanced.copilotCodingAgentV0.enabled",
 				"capabilities": {
 					"supportsFileAttachments": true
 				}
@@ -88,7 +88,7 @@
 				"displayName": "GitHub Copilot coding agent",
 				"description": "Copilot coding agent is a remote, autonomous software development agent. Developers delegate tasks to the agent, which iterates on pull requests based on feedback and reviews.",
 				"followUpRegex": "open-pull-request-webview.*((%7B.*?%7D)|(\\{.*?\\}))",
-				"when": "config.githubPullRequests.codingAgent.enabled && config.githubPullRequests.codingAgent.uiIntegration && copilotCodingAgentAssignable"
+				"when": "config.githubPullRequests.codingAgent.enabled && config.githubPullRequests.codingAgent.uiIntegration && copilotCodingAgentAssignable && config.github.copilot.chat.advanced.copilotCodingAgentV0.enabled"
 			}
 		],
 		"chatParticipants": [
@@ -616,7 +616,7 @@
 				},
 				"githubPullRequests.codingAgent.codeLens": {
 					"type": "boolean",
-					"default": false,
+					"default": true,
 					"description": "%githubPullRequests.codingAgent.codeLens.description%"
 				},
 				"githubIssues.createInsertFormat": {
@@ -3529,33 +3529,34 @@
 			"chat/chatSessions": [
 				{
 					"command": "pr.openChanges",
-					"when": "chatSessionType == copilot-swe-agent",
+					"when": "resourceScheme == copilot-swe-agent || resourceScheme == copilot-cloud-agent",
 					"group": "inline"
 				},
 				{
 					"command": "pr.checkoutChatSessionPullRequest",
-					"when": "chatSessionType == copilot-swe-agent",
+					"when": "resourceScheme == copilot-swe-agent || resourceScheme == copilot-cloud-agent",
 					"group": "context"
 				},
 				{
 					"command": "pr.closeChatSessionPullRequest",
-					"when": "chatSessionType == copilot-swe-agent",
+					"when": "resourceScheme == copilot-swe-agent",
 					"group": "context"
 				},
 				{
 					"command": "pr.cancelCodingAgent",
-					"when": "chatSessionType == copilot-swe-agent",
+					"when": "resourceScheme == copilot-swe-agent",
 					"group": "context"
 				}
 			],
 			"chat/multiDiff/context": [
 				{
-					"command": "pr.checkoutFromDescription",
-					"when": "chatSessionType == copilot-swe-agent"
+					"command": "pr.checkoutFromDescription"
 				},
 				{
-					"command": "pr.applyChangesFromDescription",
-					"when": "chatSessionType == copilot-swe-agent"
+					"command": "pr.applyChangesFromDescription"
+				},
+				{
+					"command": "pr.openChanges"
 				}
 			]
 		},
@@ -4257,7 +4258,8 @@
 		"watch": "webpack --watch --mode development --env esbuild",
 		"watch:web": "webpack --watch --mode development --config-name extension:webworker --config-name webviews",
 		"hygiene": "node ./build/hygiene.js",
-		"prepare": "husky install"
+		"prepare": "husky install",
+		"update:codicons": "npx ts-node --project tsconfig.scripts.json build/update-codicons.ts"
 	},
 	"devDependencies": {
 		"@eslint/js": "^9.36.0",
@@ -4321,6 +4323,7 @@
 		"terser-webpack-plugin": "5.1.1",
 		"timers-browserify": "^2.0.12",
 		"ts-loader": "9.5.2",
+		"ts-node": "^10.9.2",
 		"tty": "1.0.1",
 		"typescript": "^5.9.2",
 		"typescript-eslint": "^8.44.0",
@@ -4364,4 +4367,4 @@
 		"string_decoder": "^1.3.0"
 	},
 	"license": "MIT"
-}
+}