Remove deprecated review.suggestDiff command (#7822)

* Initial plan

* Remove review.suggestDiff command completely

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

* Revert test fixture changes as requested

Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: alexr00 <38270282+alexr00@users.noreply.github.com>

Author: Copilot

package.json

@@ -1041,11 +1041,6 @@
 				"title": "%command.review.openLocalFile.title%",
 				"icon": "$(go-to-file)"
 			},
-			{
-				"command": "review.suggestDiff",
-				"title": "%command.review.suggestDiff.title%",
-				"category": "%command.pull.request.category%"
-			},
 			{
 				"command": "pr.refreshList",
 				"title": "%command.pr.refreshList.title%",
@@ -2110,10 +2105,6 @@
 					"command": "pr.openSessionLogFromDescription",
 					"when": "false"
 				},
-				{
-					"command": "review.suggestDiff",
-					"when": "false"
-				},
 				{
 					"command": "review.approve",
 					"when": "false"
@@ -3067,11 +3058,6 @@
 				}
 			],
 			"scm/title": [
-				{
-					"command": "review.suggestDiff",
-					"when": "scmProvider =~ /^git|^remoteHub:github/ && scmProviderRootUri in github:reposInReviewMode",
-					"group": "inline"
-				},
 				{
 					"command": "pr.create",
 					"when": "scmProvider =~ /^git|^remoteHub:github/ && scmProviderRootUri in github:reposNotInReviewMode",

package.nls.json

@@ -205,7 +205,6 @@
 	"command.pr.checkoutByNumber.title": "Checkout Pull Request by Number",
 	"command.review.openFile.title": "Open File",
 	"command.review.openLocalFile.title": "Open File",
-	"command.review.suggestDiff.title": "Suggest Edit",
 	"command.review.approve.title": "Approve",
 	"command.review.comment.title": "Comment",
 	"command.review.requestChanges.title": "Request Changes",

src/commands.ts

@@ -285,82 +285,6 @@ export function registerCommands(
 		),
 	);
 
-	context.subscriptions.push(
-		vscode.commands.registerCommand('review.suggestDiff', async e => {
-			const hasShownMessageKey = 'githubPullRequest.suggestDiffMessage';
-			const hasShownMessage = context.globalState.get(hasShownMessageKey, false);
-			if (!hasShownMessage) {
-				await context.globalState.update(hasShownMessageKey, true);
-				const documentation = vscode.l10n.t('Open documentation');
-				const result = await vscode.window.showInformationMessage(vscode.l10n.t('You can now make suggestions from review comments, just like on GitHub.com. See the documentation for more details.'),
-					{ modal: true }, documentation);
-				if (result === documentation) {
-					return vscode.env.openExternal(vscode.Uri.parse('https://github.com/microsoft/vscode-pull-request-github/blob/main/documentation/suggestAChange.md'));
-				}
-			}
-			try {
-				const folderManager = await chooseItem<FolderRepositoryManager>(
-					reposManager.folderManagers,
-					itemValue => pathLib.basename(itemValue.repository.rootUri.fsPath),
-				);
-				if (!folderManager || !folderManager.activePullRequest) {
-					return;
-				}
-
-				const { indexChanges, workingTreeChanges } = folderManager.repository.state;
-
-				if (!indexChanges.length) {
-					if (workingTreeChanges.length) {
-						const yes = vscode.l10n.t('Yes');
-						const stageAll = await vscode.window.showWarningMessage(
-							vscode.l10n.t('There are no staged changes to suggest.\n\nWould you like to automatically stage all your of changes and suggest them?'),
-							{ modal: true },
-							yes,
-						);
-						if (stageAll === yes) {
-							await vscode.commands.executeCommand('git.stageAll');
-						} else {
-							return;
-						}
-					} else {
-						vscode.window.showInformationMessage(vscode.l10n.t('There are no changes to suggest.'));
-						return;
-					}
-				}
-
-				const diff = await folderManager.repository.diff(true);
-
-				let suggestEditMessage = vscode.l10n.t('Suggested edit:\n');
-				if (e && e.inputBox && e.inputBox.value) {
-					suggestEditMessage = `${e.inputBox.value}\n`;
-					e.inputBox.value = '';
-				}
-
-				const suggestEditText = `${suggestEditMessage}\`\`\`diff\n${diff}\n\`\`\``;
-				await folderManager.activePullRequest.createIssueComment(suggestEditText);
-
-				// Reset HEAD and then apply reverse diff
-				await vscode.commands.executeCommand('git.unstageAll');
-
-				const tempFilePath = pathLib.join(
-					folderManager.repository.rootUri.fsPath,
-					'.git',
-					`${folderManager.activePullRequest.number}.diff`,
-				);
-				const encoder = new TextEncoder();
-				const tempUri = vscode.Uri.file(tempFilePath);
-
-				await vscode.workspace.fs.writeFile(tempUri, encoder.encode(diff));
-				await folderManager.repository.apply(tempFilePath, true);
-				await vscode.workspace.fs.delete(tempUri);
-			} catch (err) {
-				const moreError = `${err}${err.stderr ? `\n${err.stderr}` : ''}`;
-				Logger.error(`Applying patch failed: ${moreError}`, logId);
-				vscode.window.showErrorMessage(vscode.l10n.t('Applying patch failed: {0}', formatError(err)));
-			}
-		}),
-	);
-
 	context.subscriptions.push(
 		vscode.commands.registerCommand('pr.openFileOnGitHub', async (e: GitFileChangeNode | RemoteFileChangeNode) => {
 			if (e instanceof RemoteFileChangeNode) {