Exploration: Can we simplify the default set of queries?

[chrisdias]

PR and Issue queries look and behave slightly differently. Overall, it seems like we could simplify the default experience/list of queries for each, providing that users can still customize them through settings. A breakdown:

PR Queries

• Defaults

  • Local PR Branches
  • Waiting for my Review
  • Assigned to Me
  • Created by Me
  • All Open

• You can edit the queries by clicking “…” on the PULL REQUESTS sash, then choosing “Configure”, then “Configure queries…” from the Quick Pick, and then in the Settings editor choose “Edit in settings.json”, which will take you to three of the 5 queries.

• "All Open" and "Local Pull Request Branches" are not configurable, why not?
• Once queries exist in settings.json, you can click on the pencil to edit them in the Quick Pick or jump back to settings.json (but you can’t do this with All Open, Local PR Branches)

• When you create a new query, you get prompted for a name and then a prepopulated GH query

• An empty object in settings.json will give you just the two “All Open” and “Local PR Branches” queries!

Issues Queries

• Defaults
  • My Issues (grouped by Milestone)
  • Created Issues (open by me)
  • Recent Issues (all open issues)
• I can edit the queries the same way I do PRs, click on … then configure…
• Duplicates and query errors are handled slightly differently, you don’t get an error it just either throws away all queries and remembers the last good state, or it shows just one of multiple duplicates
• What’s nice about Issues is that if I have just one query the issues are shown as a flat list without a hierarchy under the query name

• From here I can edit the queries by clicking on the pencil icon in the tree, but I don’t get the multi-step editing experience as with PR queries, I jump right to settings.json.

Suggestions

• Pull Requests

  • Local PR Branches – I get why this exists, it’s what I’ve been working on. Ideally its “work in progress”, is that true? If so, consider renaming “Reviews in Progress”
  • Assigned to Me
  • All Open PRs

• Issues

  • Assigned to Me – drop the grouping by milestone for the sake of simplicity
  • Created by Me
  • All Open Issues - this was “Recent Issues”, not sure why its “Recent” but change the naming to match “All Open PRs”

• Make the editing of queries the same across all views

[rothman857]

Upvote (for whatever that's worth). Making all the default queries configurable/removable would be nice. I only care about PR's that are assigned to / created by me.