Test default queries in Pull Requests view

[alexr00]

Refs: #6754

• anyOS @binderjoe
• anyOS @Yoyokrazy
• anyOS @deepak1556

Complexity: 3

Create Issue

---

Background

The Pull Requests view has always been configurable with the setting githubPullRequests.queries. Example:

  "githubPullRequests.queries": [
    {
      "label": "Waiting For My Review",
      "query": "repo:${owner}/${repository} is:open review-requested:${user}"
    },
    {
      "label": "Created By Me",
      "query": "repo:${owner}/${repository} is:open author:${user}"
    },
  ]

Would result in

You can see that there are only 2 queries in the setting, but 4 headings in the queries view. The "Local Pull Request Branches" and "All Open" were defaults that couldn't be removed. With the change, all of those queries are removable.

NOTE: If you have a repo open that supports assigning to Copilot then you'll also see a "Copilot on My Behalf" query, which only shows in the Pull Requests view and is not configurable via setting.

Setup

• Have a clone of a GitHub repo

Migration testing

As part of making these queries more configurable, there needed to be a setting migration. To verify:

• Open your clone of a GitHub repo
• Create a new profile that inherits nothing, and switch to it
• Search for "GitHub Pull Request" in the Extensions view and right click -> install specific version. Choose a 0.109 version.
• Open your profile's settings and configure githubPullRequests.queries to something.
• Verify that you see your configured value in the Pull Requests view
• From the Extensions view, right click on GitHub Pull Requests -> install specific version, and choose the most recent pre-release version
• Check your configured value of githubPullRequests.queries. Verify that it now has the "Local Pull Request Branches" and "All Open" items.
• Verify that these items also show in the Pull Requests view.

Other testing

• Verify that you can delete one or both of the "Local Pull Request Branches" and "All Open" queries.