Mark All as Read feedback

[benibenj]

Also, I would have expected the wording to be the same. So Dismiss Notification and Dismiss All Notifications or Mark as Read and Mark All as Read.

I would also expect this action to be available on other Query nodes (such as All Open) as Notifications are available on all kinds of PRs

Originally posted by @benibenj in #7858

[alexr00]

We have two different kinds of notifications. They need to be reconciled.

[bamurtaugh]

Filing here as it's also Mark All as Read feedback - if I'm using Mark All as Read incorrectly, or if this should be a separate issue, please just let me know-

The coding agent just finished working on a PR, but when I right-click to mark it as read, the option is grayed out:

[alexr00]

@bamurtaugh do you also have "githubPullRequests.notifications": "pullRequests" set?

[bamurtaugh]

do you also have "githubPullRequests.notifications": "pullRequests" set?

No, this is set to off for me. I'm guessing then that needed to be set to pullRequests for me for this to work?

[bamurtaugh]

Hmm so I set "githubPullRequests.notifications": "pullRequests":

but the option is still grayed out:

I noticed there was no (1) in the GHPR Activity Bar icon, which makes me think something else may be an issue here? I reloaded VS Code, and now everything is marked as read (even though I didn't newly open or close any PR views):

Wonder if this could at all be tied to the issue I'm seeing with #7916.