From 713e57ee941bdcc24cae8f55e6ef831598a53bfb Mon Sep 17 00:00:00 2001 From: Alex Ross <38270282+alexr00@users.noreply.github.com> Date: Mon, 10 Nov 2025 18:14:27 +0100 Subject: [PATCH 1/2] Extend disposable --- src/view/pullRequestCommentControllerRegistry.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/view/pullRequestCommentControllerRegistry.ts b/src/view/pullRequestCommentControllerRegistry.ts index b21c5f7145..0f904f26da 100644 --- a/src/view/pullRequestCommentControllerRegistry.ts +++ b/src/view/pullRequestCommentControllerRegistry.ts @@ -14,13 +14,13 @@ import { GHPRComment } from '../github/prComment'; import { PullRequestModel } from '../github/pullRequestModel'; import { CommentReactionHandler } from '../github/utils'; -interface PullRequestCommentHandlerInfo { +interface PullRequestCommentHandlerInfo extends vscode.Disposable { handler: PullRequestCommentController & CommentReactionHandler; refCount: number; dispose: () => void; } -interface PRCommentingRangeProviderInfo { +interface PRCommentingRangeProviderInfo extends vscode.Disposable { provider: vscode.CommentingRangeProvider2; refCount: number; dispose: () => void; From 05d5ead6815159d48865cc27f0b5af4fb5a9f30d Mon Sep 17 00:00:00 2001 From: Alex Ross <38270282+alexr00@users.noreply.github.com> Date: Mon, 10 Nov 2025 18:20:04 +0100 Subject: [PATCH 2/2] clean up --- src/view/pullRequestCommentControllerRegistry.ts | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/view/pullRequestCommentControllerRegistry.ts b/src/view/pullRequestCommentControllerRegistry.ts index 0f904f26da..e4eeb6ad12 100644 --- a/src/view/pullRequestCommentControllerRegistry.ts +++ b/src/view/pullRequestCommentControllerRegistry.ts @@ -17,13 +17,11 @@ import { CommentReactionHandler } from '../github/utils'; interface PullRequestCommentHandlerInfo extends vscode.Disposable { handler: PullRequestCommentController & CommentReactionHandler; refCount: number; - dispose: () => void; } interface PRCommentingRangeProviderInfo extends vscode.Disposable { provider: vscode.CommentingRangeProvider2; refCount: number; - dispose: () => void; } export class PRCommentControllerRegistry extends Disposable implements vscode.CommentingRangeProvider, CommentReactionHandler {