Remove experimental from Font Install, Uninstall, and source (#5791)

This removes experimental from font install, uninstall, and source.

The font command remains experimental and is not required to install or
remove fonts, which use the normal install and uninstall flow for a
WinGet package.

<!-- To check a checkbox place an "x" between the brackets. e.g: [x] -->

- [x] I have signed the [Contributor License
Agreement](https://cla.opensource.microsoft.com/microsoft/winget-pkgs).
- [x] I have updated the [Release Notes](../doc/ReleaseNotes.md).
- [ ] This pull request is related to an issue.

-----

###### Microsoft Reviewers: [Open in
CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5791)

---------

Co-authored-by: John McPherson <johnmcp@microsoft.com>

Author: dkbennett

doc/ReleaseNotes.md

@@ -2,14 +2,29 @@
 * MCP server available; run `winget mcp` for assistance on configuring your client.
 * App Installer now uses WinUI 3. The package dependency on WinUI 2 has been replaced by a dependency on the Windows App Runtime 1.8.
 * Manifest schema and validation updated to v1.12. This version update adds `Font` as an `InstallerType` and `NestedInstallerType`.
+* Font Install, Uninstall, and a winget-fonts source have been added and are non-experimental.
 
 ## Bug Fixes
 * Manifest validation no longer fails using `UTF-8 BOM` encoding when the schema header is on the first line
 * Upgrading a portable package with dev mode disabled will no longer remove the package from the PATH variable.
 * Fixed source open failure when there were multiple sources but less than two non-explicit sources.
 
+## Font Support
+Font Install and Uninstall via manifest and package source for user and machine scopes has been added.
+A sample Font manifest can be found at:
+https://github.com/microsoft/winget-pkgs/tree/master/fonts/m/Microsoft/FluentFonts/1.0.0.0
+
+At this time install and removal of fonts is only supported for fonts installed via WinGet Package.
+
+Fonts must either be the Installer or a .zip archive of NestedInstaller fonts.
+
+A new explicit source for fonts has been added "winget-font".
+```winget search font -s winget-font```
+
+This source is not yet accepting public submissions at this time.
+
 ## Experimental Features
-* Experimental support for Fonts
+* Experimental support still exists for the 'font' command.
 
 ---
 ### Experimental support for Fonts
@@ -22,8 +37,4 @@ The following snippet enables experimental support for fonts via `winget setting
   }
 }
 ```
-Manifest Schema version updated to 1.12.0 to add support for fonts.
-
-Experimental initial Font Install and Uninstall via manifest for user and machine scopes has been added.
-
 The font 'list' command has been updated with a new '--details' feature for an alternate view of the installed fonts.

samples/WinGetUWPCaller/WinGetUWPCaller/MainPage.cpp

@@ -309,13 +309,16 @@ namespace winrt::WinGetUWPCaller::implementation
 
                 if (selectedItems.Size() == 0)
                 {
-                    // If no items are selected, we use all available catalogs.
+                    // If no items are selected, we use all implicit catalogs.
                     CreateCompositePackageCatalogOptions createCompositePackageCatalogOptions;
                     createCompositePackageCatalogOptions.CompositeSearchBehavior(CompositeSearchBehavior::RemotePackagesFromRemoteCatalogs);
 
                     for (const auto& item : m_packageManager.GetPackageCatalogs())
                     {
-                        createCompositePackageCatalogOptions.Catalogs().Append(item);
+                        if (!item.Info().Explicit())
+                        {
+                            createCompositePackageCatalogOptions.Catalogs().Append(item);
+                        }
                     }
 
                     catalogReference = m_packageManager.CreateCompositePackageCatalog(createCompositePackageCatalogOptions);

src/AppInstallerCLICore/Workflows/InstallFlow.cpp

@@ -285,7 +285,6 @@ namespace AppInstaller::CLI::Workflow
         void FontInstall(Execution::Context& context)
         {
             context <<
-                EnsureFeatureEnabled(ExperimentalFeature::Feature::Font) <<
                 GetInstallerArgs <<
                 FontInstallImpl <<
                 ReportInstallerResult("Font"sv, APPINSTALLER_CLI_ERROR_FONT_INSTALL_FAILED, true);

src/AppInstallerCLICore/Workflows/UninstallFlow.cpp

@@ -354,7 +354,6 @@ namespace AppInstaller::CLI::Workflow
             break;
         case InstallerTypeEnum::Font:
             context <<
-                EnsureFeatureEnabled(Settings::ExperimentalFeature::Feature::Font) <<
                 Workflow::FontUninstallImpl <<
                 ReportUninstallerResult("Font"sv, APPINSTALLER_CLI_ERROR_FONT_UNINSTALL_FAILED, true);
             break;

src/AppInstallerCLIE2ETests/GroupPolicy.cs

@@ -166,9 +166,7 @@ public void EnableMicrosoftStoreSource()
         [Test]
         public void EnableFontSource()
         {
-            WinGetSettingsHelper.ConfigureFeature("fonts", true);
             GroupPolicyHelper.EnableFontSource.Disable();
-
             var result = TestCommon.RunAICLICommand("source list", "winget-font");
             Assert.AreEqual(Constants.ErrorCode.ERROR_SOURCE_NAME_DOES_NOT_EXIST, result.ExitCode);
 

src/AppInstallerCLITests/Sources.cpp

@@ -23,7 +23,7 @@ using namespace AppInstaller::Utility;
 using namespace std::string_literals;
 using namespace std::string_view_literals;
 
-constexpr size_t c_DefaultSourceCount = 2;
+constexpr size_t c_DefaultSourceCount = 3;
 
 constexpr std::string_view s_SourcesYaml_Sources = "Sources"sv;
 constexpr std::string_view s_SourcesYaml_Source_Name = "Name"sv;
@@ -50,6 +50,11 @@ constexpr std::string_view s_DefaultSourcesTombstoned = R"(
     Arg: ""
     Data: ""
     IsTombstone: true
+  - Name: winget-font
+    Type: ""
+    Arg: ""
+    Data: ""
+    IsTombstone: true
 )"sv;
 
 constexpr std::string_view s_SingleSource = R"(
@@ -122,6 +127,11 @@ constexpr std::string_view s_ThreeSources = R"(
     Arg: ""
     Data: ""
     IsTombstone: true
+  - Name: winget-font
+    Type: ""
+    Arg: ""
+    Data: ""
+    IsTombstone: true
 )"sv;
 
 constexpr std::string_view s_ThreeSourcesMetadata = R"(

src/AppInstallerRepositoryCore/SourcePolicy.cpp

@@ -191,7 +191,7 @@ namespace AppInstaller::Repository
         case AppInstaller::Repository::WellKnownSource::MicrosoftStore:
             return IsDefaultSourceEnabled(source, ExperimentalFeature::Feature::None, onlyExplicit, TogglePolicy::Policy::MSStoreSource);
         case AppInstaller::Repository::WellKnownSource::WinGetFont:
-            return IsDefaultSourceEnabled(source, ExperimentalFeature::Feature::Font, onlyExplicit, TogglePolicy::Policy::FontSource);
+            return IsDefaultSourceEnabled(source, ExperimentalFeature::Feature::None, onlyExplicit, TogglePolicy::Policy::FontSource);
         case AppInstaller::Repository::WellKnownSource::DesktopFrameworks:
             // No corresponding policy available for this source.
             return true;

src/PowerShell/Microsoft.WinGet.Client.Engine/Commands/Common/FinderCommand.cs

@@ -160,7 +160,23 @@ private PackageCatalogReference GetPackageCatalogReference(CompositeSearchBehavi
             IReadOnlyList<PackageCatalogReference> references = this.GetPackageCatalogReferences(this.Source);
             for (var i = 0; i < references.Count; i++)
             {
-                options.Catalogs.Add(references[i]);
+                var reference = references[i];
+                bool isExplicit = false;
+                try
+                {
+                    // Execute in try block to catch interface not implemented on older servers.
+                    isExplicit = reference.Info.Explicit;
+                }
+                catch
+                {
+                    // Assume that any failure other than the interface not implemented to get Explicit
+                    // will result in other failures shortly after this (like the server being gone).
+                }
+
+                if (!isExplicit)
+                {
+                    options.Catalogs.Add(reference);
+                }
             }
 
             options.CompositeSearchBehavior = behavior;

src/PowerShell/Microsoft.WinGet.Client.Engine/Commands/SourceCommand.cs

@@ -1,4 +1,4 @@
-// -----------------------------------------------------------------------------
+// -----------------------------------------------------------------------------
 // <copyright file="SourceCommand.cs" company="Microsoft Corporation">
 //     Copyright (c) Microsoft Corporation. Licensed under the MIT License.
 // </copyright>

src/PowerShell/tests/Microsoft.WinGet.DSC.Tests.ps1

@@ -171,7 +171,7 @@ Describe 'WinGetPackage' {
         $testPackageId = 'AppInstallerTest.TestExeInstaller'
         $testPackageVersion = '1.0.0.0'
 
-        InvokeWinGetDSC -Name WinGetSource -Method Set -Property @{ Name = $testSourceName; Argument = $testSourceArg; Type = $testSourceType; TrustLevel = 'Trusted' }
+        InvokeWinGetDSC -Name WinGetSource -Method Set -Property @{ Name = $testSourceName; Argument = $testSourceArg; Type = $testSourceType; TrustLevel = 'Trusted'; Explicit = $false }
     }
 
     It 'Get WinGetPackage' {