Merge pull request #1800 from miguelpruivo/feature/restore-linter-on-example-project

Restore Linter on example's project

Author: navaronbracke

analysis_options.yaml

@@ -1,42 +1 @@
-include: package:lints/recommended.yaml
-
-analyzer:
-  exclude:
-    - build/**
-    - example/**
-    - lib/generated_plugin_registrant.dart
-#   language:
-#     strict-raw-types: true
-#   strong-mode:
-#     implicit-casts: false
-
-linter:
-  rules:
-    # - cancel_subscriptions
-    - comment_references
-    - slash_for_doc_comments
-    - use_key_in_widget_constructors
-    - unnecessary_statements
-    - throw_in_finally
-    - always_use_package_imports
-    - avoid_dynamic_calls
-    - avoid_empty_else
-    # - avoid_print
-    - avoid_relative_lib_imports
-    - avoid_slow_async_io
-    - avoid_type_to_string
-    - avoid_types_as_parameter_names
-    - avoid_web_libraries_in_flutter
-    - cancel_subscriptions
-    - close_sinks
-    - control_flow_in_finally
-    - diagnostic_describe_all_properties
-    - empty_statements
-    - hash_and_equals
-    - collection_methods_unrelated_type
-    - literal_only_boolean_expressions
-    - no_adjacent_strings_in_list
-    - no_duplicate_case_values
-    - no_logic_in_create_state
-    - prefer_void_to_null
-    - test_types_in_equals
+include: package:lints/recommended.yaml

example/lib/src/file_picker_demo.dart

@@ -1,14 +1,14 @@
-import 'dart:convert';
-
 import 'package:file/local.dart';
 import 'package:file_picker/file_picker.dart';
 import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter/services.dart';
 
 class FilePickerDemo extends StatefulWidget {
+  const FilePickerDemo({super.key});
+
   @override
-  _FilePickerDemoState createState() => _FilePickerDemoState();
+  State<FilePickerDemo> createState() => _FilePickerDemoState();
 }
 
 class _FilePickerDemoState extends State<FilePickerDemo> {
@@ -36,7 +36,7 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
                 Icons.error_outline,
               ),
               contentPadding: EdgeInsets.symmetric(vertical: 40.0),
-              title: const Text('No action taken yet'),
+              title: Text('No action taken yet'),
               subtitle: Text(
                 'Please use on one of the buttons above to get started',
                 style: TextStyle(
@@ -80,7 +80,7 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
       pickedFiles = (await FilePicker.platform.pickFiles(
         type: _pickingType,
         allowMultiple: _multiPick,
-        onFileLoading: (FilePickerStatus status) => print(status),
+        onFileLoading: (FilePickerStatus status) => printInDebug(status),
         allowedExtensions: (_extension?.isNotEmpty ?? false)
             ? _extension?.replaceAll(' ', '').split(',')
             : null,
@@ -92,7 +92,7 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
           ?.files;
       hasUserAborted = pickedFiles == null;
     } on PlatformException catch (e) {
-      _logException('Unsupported operation' + e.toString());
+      _logException('Unsupported operation: $e');
     } catch (e) {
       _logException(e.toString());
     }
@@ -135,7 +135,7 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
       );
       hasUserAborted = pickedFilesAndDirectories == null;
     } on PlatformException catch (e) {
-      _logException('Unsupported operation' + e.toString());
+      _logException('Unsupported operation: $e');
     } catch (e) {
       _logException(e.toString());
     }
@@ -185,7 +185,7 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
         ),
       );
     } on PlatformException catch (e) {
-      _logException('Unsupported operation' + e.toString());
+      _logException('Unsupported operation: $e');
     } catch (e) {
       _logException(e.toString());
     }
@@ -207,7 +207,7 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
       );
       hasUserAborted = pickedDirectoryPath == null;
     } on PlatformException catch (e) {
-      _logException('Unsupported operation' + e.toString());
+      _logException('Unsupported operation: $e');
     } catch (e) {
       _logException(e.toString());
     }
@@ -247,7 +247,7 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
       );
       hasUserAborted = pickedSaveFilePath == null;
     } on PlatformException catch (e) {
-      _logException('Unsupported operation' + e.toString());
+      _logException('Unsupported operation: $e');
     } catch (e) {
       _logException(e.toString());
     }
@@ -269,7 +269,7 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
   }
 
   void _logException(String message) {
-    print(message);
+    printInDebug(message);
     _scaffoldMessengerKey.currentState?.hideCurrentSnackBar();
     _scaffoldMessengerKey.currentState?.showSnackBar(
       SnackBar(
@@ -373,8 +373,8 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
                         items: FileType.values
                             .map(
                               (fileType) => DropdownMenuItem<FileType>(
-                                child: Text(fileType.toString()),
                                 value: fileType,
+                                child: Text(fileType.toString()),
                               ),
                             )
                             .toList(),
@@ -569,4 +569,6 @@ class _FilePickerDemoState extends State<FilePickerDemo> {
       ),
     );
   }
+
+  void printInDebug(Object object) => debugPrint(object.toString());
 }

example/pubspec.yaml

@@ -1,21 +1,21 @@
 name: file_picker_example
 description: An example of how to use the file_picker plugin.
-version: 1.0.0+1
+publish_to: 'none' # Remove this line if you wish to publish to pub.dev
 
 environment:
   sdk: ">=2.19.0 <4.0.0"
 
 dependencies:
   flutter:
     sdk: flutter
+  file_picker:
+    path: ../
   file: ^7.0.1
 
 dev_dependencies:
   flutter_test:
     sdk: flutter
-
-  file_picker:
-    path: ../
+  flutter_lints: ^5.0.0
 
 flutter:
   uses-material-design: true