Skip to content

Commit dd46140

Browse files
♻️ fix minor issues with param syntaxes & tests (#408)
1 parent 6646123 commit dd46140

File tree

2 files changed

+26
-25
lines changed

2 files changed

+26
-25
lines changed

src/input/dataSchema.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -126,8 +126,8 @@ export class DataSchema {
126126
constructor(dataSchema: StringDict | string) {
127127
if (typeof dataSchema === "string") {
128128
this.replace = new DataSchemaReplace(JSON.parse(dataSchema)["replace"]);
129-
} else if (dataSchema["replace"] instanceof DataSchemaReplace) {
130-
this.replace = dataSchema["replace"];
129+
} else if (dataSchema instanceof DataSchema) {
130+
this.replace = dataSchema.replace;
131131
} else {
132132
this.replace = new DataSchemaReplace(dataSchema["replace"] as StringDict);
133133
}

tests/v2/input/inferenceParameter.spec.ts

Lines changed: 24 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -18,31 +18,32 @@ describe("MindeeV2 - Inference Parameter", () => {
1818
expectedDataSchemaObject = new DataSchema(expectedDataSchemaDict);
1919
});
2020

21-
it("shouldn't replace when unset", async () => {
22-
const params: InferenceParameters = {
23-
modelId: "test-model-id",
24-
};
21+
describe("dataSchema", () => {
22+
it("shouldn't replace when unset", async () => {
23+
const params: InferenceParameters = {
24+
modelId: "test-model-id",
25+
};
2526

26-
expect(params.dataSchema).to.be.undefined;
27-
});
27+
expect(params.dataSchema).to.be.undefined;
28+
});
2829

29-
it("should equate no matter the type", async () => {
30-
const paramsDict: InferenceParameters = {
31-
modelId: "test-model-id",
32-
dataSchema: expectedDataSchemaDict,
33-
};
34-
const paramsString: InferenceParameters = {
35-
modelId: "test-model-id",
36-
dataSchema: expectedDataSchemaString,
37-
};
38-
const paramsObject: InferenceParameters = {
39-
modelId: "test-model-id",
40-
dataSchema: expectedDataSchemaObject,
41-
};
30+
it("should equate no matter the type", async () => {
31+
const paramsDict: InferenceParameters = {
32+
modelId: "test-model-id",
33+
dataSchema: expectedDataSchemaDict,
34+
};
35+
const paramsString: InferenceParameters = {
36+
modelId: "test-model-id",
37+
dataSchema: expectedDataSchemaString,
38+
};
39+
const paramsObject: InferenceParameters = {
40+
modelId: "test-model-id",
41+
dataSchema: expectedDataSchemaObject,
42+
};
4243

43-
expect(JSON.stringify(paramsDict.dataSchema)).to.eq(expectedDataSchemaString);
44-
expect(paramsObject.dataSchema?.toString()).to.eq(expectedDataSchemaString);
45-
expect(paramsString.dataSchema?.toString()).to.eq(expectedDataSchemaString);
44+
expect(JSON.stringify(paramsDict.dataSchema)).to.eq(expectedDataSchemaString);
45+
expect(paramsObject.dataSchema?.toString()).to.eq(expectedDataSchemaString);
46+
expect(paramsString.dataSchema?.toString()).to.eq(expectedDataSchemaString);
47+
});
4648
});
47-
4849
});

0 commit comments

Comments
 (0)