Skip to content

Commit dff07fb

Browse files
Minor doc changes (#872)
* Minor doc changes Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Michele Bastione <michele.bastione@gmail.com>
1 parent 7d63280 commit dff07fb

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

MiniExcel.slnx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
<File Path="README-NuGet.md" />
1212
<File Path="README.md" />
1313
<File Path="README.zh-CN.md" />
14-
<File Path="README.zh-Hant.md" />
1514
<File Path=".github\workflows\benchmark.yml" />
1615
<File Path=".github\workflows\codeql-analysis.yml" />
1716
<File Path="src\Directory.Build.props" />

README-V2.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
---
6464

6565
<div align="center">
66-
If MiniExcel was useful to you please <a href="https://github.com/mini-software/MiniExcel">star</a> the project and consider <a href="https://miniexcel.github.io">donating</a>. A small gesture can make a big difference in improving the library!
66+
If MiniExcel was useful to you please consider <a href="https://miniexcel.github.io">donating</a>, or simply <a href="https://github.com/mini-software/MiniExcel">starring</a> the project. A small gesture can make a big difference in improving the library!
6767
</div>
6868

6969
---
@@ -108,7 +108,8 @@ dotnet add package MiniExcel
108108
```
109109

110110
This package will contain the assemblies with both Excel and Csv functionalities, along with the original `v1.x` methods' signatures.
111-
If you don't care for those you can also install the Excel and Csv packages separately:
111+
~~If you don't care for those you can also install the Excel and Csv packages separately:~~
112+
We're still pondering whether this is the best way to move forward with the library, and if we do this is how you'll be able to add the separate packages:
112113

113114
```bash
114115
dotnet add package MiniExcel.Core

V2-Upgrade-Notes.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
`MiniExcel.Importers`, `MiniExcel.Exporters` and `MiniExcel.Templaters` will give you access to, respectively, the `MiniExcelImporterProvider`, `MiniExcelExporterProvider` and `MiniExcelTemplaterProvider`.
77
- This way Excel and Csv query methods are split between the `OpenXmlImporter` and the `CsvImporter`, accessible from the `MiniExcelImporterProvider`.
88
- The same structure was adopted for export methods through `OpenXmlExporter` and `CsvExporter`, while template methods are instead currently only found in `OpenXmlTemplater`.
9-
- Csv methods are only available if the MiniExcel.Csv package is installed, which is pulled down automatically when the full MiniExcel package is downloaded.
9+
- ~~Csv methods are only available if the MiniExcel.Csv package is installed, which is pulled down automatically when the full MiniExcel package is downloaded.~~
10+
We're still pondering whether this is the best way to move forward with the library, currently only the full MiniExcel package is available.
1011
- If the full MiniExcel package is downloaded, the previous namespace will coexist along the new one, containing the original static methods' signatures, which have become a facade for the aferomentioned providers.
1112
- `IConfiguration` is now `IMiniExcelConfiguration`, but most methods now require the proper implementation (`OpenXmlConfiguration` or `CsvConfiguration`) to be provided rather than the interface
1213
- MiniExcel now fully supports asynchronous streaming the queries,

0 commit comments

Comments
 (0)