Skip to content

Commit 2744604

Browse files
also ignore unknown properties in capabilities.sampling
1 parent 0c7dadc commit 2744604

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

mcp-core/src/main/java/io/modelcontextprotocol/spec/McpSchema.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,7 @@ public record RootCapabilities(@JsonProperty("listChanged") Boolean listChanged)
407407
* from MCP servers in their prompts.
408408
*/
409409
@JsonInclude(JsonInclude.Include.NON_ABSENT)
410+
@JsonIgnoreProperties(ignoreUnknown = true)
410411
public record Sampling() {
411412
}
412413

mcp-core/src/test/java/io/modelcontextprotocol/spec/McpSchemaTests.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -358,12 +358,15 @@ void testInitializeResult() throws Exception {
358358
// see https://github.com/modelcontextprotocol/java-sdk/issues/724
359359
void testParseInitializeRequest() throws IOException {
360360
String serialized = """
361-
{"protocolVersion":"2024-11-05","capabilities":{"elicitation":{"form":{}}},"clientInfo":{"name":"test-client","version":"1.0.0"},"_meta":{"metaKey":"metaValue"}}
361+
{"protocolVersion":"2024-11-05","capabilities":{"elicitation":{"form":{}},"sampling":{"tools": {}}},"clientInfo":{"name":"test-client","version":"1.0.0"},"_meta":{"metaKey":"metaValue"}}
362362
""";
363363

364364
McpSchema.InitializeRequest deserialized = JSON_MAPPER.readValue(serialized, McpSchema.InitializeRequest.class);
365365

366-
McpSchema.ClientCapabilities capabilities = McpSchema.ClientCapabilities.builder().elicitation().build();
366+
McpSchema.ClientCapabilities capabilities = McpSchema.ClientCapabilities.builder()
367+
.elicitation()
368+
.sampling()
369+
.build();
367370
McpSchema.Implementation clientInfo = new McpSchema.Implementation("test-client", "1.0.0");
368371
Map<String, Object> meta = Map.of("metaKey", "metaValue");
369372
McpSchema.InitializeRequest expected = new McpSchema.InitializeRequest(ProtocolVersions.MCP_2024_11_05,

0 commit comments

Comments
 (0)