fix(tests): Failed to start process with command npx on Windows platform while running mvn test

Author: codeboyzhou

mcp/src/test/java/io/modelcontextprotocol/client/StdioMcpAsyncClientTests.java

@@ -22,14 +22,18 @@ class StdioMcpAsyncClientTests extends AbstractMcpAsyncClientTests {
 
 	@Override
 	protected McpClientTransport createMcpTransport() {
-		ServerParameters stdioParams = ServerParameters.builder("npx")
-			.args("-y", "@modelcontextprotocol/server-everything", "dir")
-			.build();
-		ServerParameters windowsStdioParams = ServerParameters.builder("cmd.exe")
-			.args("/c", "npx.cmd", "-y", "@modelcontextprotocol/server-everything", "dir")
-			.build();
-		boolean isWindows = System.getProperty("os.name").toLowerCase().contains("win");
-		return new StdioClientTransport(isWindows ? windowsStdioParams : stdioParams);
+		ServerParameters stdioParams;
+		if (System.getProperty("os.name").toLowerCase().contains("win")) {
+			stdioParams = ServerParameters.builder("cmd.exe")
+				.args("/c", "npx.cmd", "-y", "@modelcontextprotocol/server-everything", "dir")
+				.build();
+		}
+		else {
+			stdioParams = ServerParameters.builder("npx")
+				.args("-y", "@modelcontextprotocol/server-everything", "dir")
+				.build();
+		}
+		return new StdioClientTransport(stdioParams);
 	}
 
 	protected Duration getInitializationTimeout() {

mcp/src/test/java/io/modelcontextprotocol/client/StdioMcpSyncClientTests.java

@@ -30,14 +30,18 @@ class StdioMcpSyncClientTests extends AbstractMcpSyncClientTests {
 
 	@Override
 	protected McpClientTransport createMcpTransport() {
-		ServerParameters stdioParams = ServerParameters.builder("npx")
-			.args("-y", "@modelcontextprotocol/server-everything", "dir")
-			.build();
-		ServerParameters windowsStdioParams = ServerParameters.builder("cmd.exe")
-			.args("/c", "npx.cmd", "-y", "@modelcontextprotocol/server-everything", "dir")
-			.build();
-		boolean isWindows = System.getProperty("os.name").toLowerCase().contains("win");
-		return new StdioClientTransport(isWindows ? windowsStdioParams : stdioParams);
+		ServerParameters stdioParams;
+		if (System.getProperty("os.name").toLowerCase().contains("win")) {
+			stdioParams = ServerParameters.builder("cmd.exe")
+				.args("/c", "npx.cmd", "-y", "@modelcontextprotocol/server-everything", "dir")
+				.build();
+		}
+		else {
+			stdioParams = ServerParameters.builder("npx")
+				.args("-y", "@modelcontextprotocol/server-everything", "dir")
+				.build();
+		}
+		return new StdioClientTransport(stdioParams);
 	}
 
 	@Test