remove prints and change test class, use snapshot

Author: yannj-fr

tests/server/fastmcp/auth/test_auth_integration.py

@@ -11,6 +11,7 @@
 
 import httpx
 import pytest
+from inline_snapshot import snapshot
 from pydantic import AnyHttpUrl
 from starlette.applications import Starlette
 
@@ -197,7 +198,7 @@ def mock_oauth_provider():
 
 
 @pytest.fixture
-def auth_app(mock_oauth_provider):
+def auth_app(mock_oauth_provider: MockOAuthProvider):
     # Create auth router
     auth_routes = create_auth_routes(
         mock_oauth_provider,
@@ -218,25 +219,7 @@ def auth_app(mock_oauth_provider):
 
 
 @pytest.fixture
-def protected_resource_app(auth_app):
-    """Fixture to create protected resource routes for testing."""
-
-    # Create the protected resource routes
-    protected_resource_routes = create_protected_resource_routes(
-        resource_url=AnyHttpUrl("https://example.com/resource"),
-        authorization_servers=[AnyHttpUrl("https://auth.example.com/authorization")],
-        scopes_supported=["read", "write"],
-        resource_name="Example Resource",
-        resource_documentation=AnyHttpUrl("https://docs.example.com/resource"),
-    )
-
-    # add routes to the auth app
-    auth_app.router.routes.extend(protected_resource_routes)
-    return auth_app
-
-
-@pytest.fixture
-async def test_client(auth_app):
+async def test_client(auth_app: Starlette):
     async with httpx.AsyncClient(transport=httpx.ASGITransport(app=auth_app), base_url="https://mcptest.com") as client:
         yield client
 
@@ -268,6 +251,32 @@ async def registered_client(test_client: httpx.AsyncClient, request):
     return client_info
 
 
+@pytest.fixture
+def protected_resource_app():
+    """Fixture to create protected resource routes for testing."""
+
+    # Create the protected resource routes
+    protected_resource_routes = create_protected_resource_routes(
+        resource_url=AnyHttpUrl("https://example.com/resource"),
+        authorization_servers=[AnyHttpUrl("https://auth.example.com/authorization")],
+        scopes_supported=["read", "write"],
+        resource_name="Example Resource",
+        resource_documentation=AnyHttpUrl("https://docs.example.com/resource"),
+    )
+
+    app = Starlette(routes=protected_resource_routes)
+    return app
+
+
+@pytest.fixture
+async def protected_resource_test_client(protected_resource_app: Starlette):
+    """Fixture to create an HTTP client for the protected resource app."""
+    async with httpx.AsyncClient(
+        transport=httpx.ASGITransport(app=protected_resource_app), base_url="https://mcptest.com"
+    ) as client:
+        yield client
+
+
 @pytest.fixture
 def pkce_challenge():
     """Create a PKCE challenge with code_verifier and code_challenge."""
@@ -354,7 +363,7 @@ class TestAuthEndpoints:
     @pytest.mark.anyio
     async def test_metadata_endpoint(self, test_client: httpx.AsyncClient):
         """Test the OAuth 2.0 metadata endpoint."""
-        
+
         response = await test_client.get("/.well-known/oauth-authorization-server")
         assert response.status_code == 200
 
@@ -1221,15 +1230,19 @@ class TestProtectedResourceMetadata:
     """Test the Protected Resource Metadata model."""
 
     @pytest.mark.anyio
-    async def test_metadata_endpoint(self, protected_resource_app: Starlette, test_client: httpx.AsyncClient):
+    async def test_metadata_endpoint(self, protected_resource_test_client: httpx.AsyncClient):
         """Test the OAuth 2.0 Protected Resource metadata endpoint."""
-        
-        response = await test_client.get("/.well-known/oauth-protected-resource")
+
+        response = await protected_resource_test_client.get("/.well-known/oauth-protected-resource")
         assert response.status_code == 200
         metadata = response.json()
-        assert metadata["resource"] == "https://example.com/resource"
-        assert metadata["authorization_servers"] == ["https://auth.example.com/authorization"]
-        assert metadata["scopes_supported"] == ["read", "write"]
-        assert metadata["resource_name"] == "Example Resource"
-        assert metadata["resource_documentation"] == "https://docs.example.com/resource"
-        assert metadata["bearer_methods_supported"] == ["header"]
+        assert metadata == snapshot(
+            {
+                "resource": "https://example.com/resource",
+                "authorization_servers": ["https://auth.example.com/authorization"],
+                "scopes_supported": ["read", "write"],
+                "resource_name": "Example Resource",
+                "resource_documentation": "https://docs.example.com/resource",
+                "bearer_methods_supported": ["header"],
+            }
+        )