Skip to content

Commit 161e513

Browse files
committed
fix: complete timeout float standardization
- Remove .total_seconds() calls in session_group.py (values are now floats) - Update test_streamable_http.py to use float timeout values - Change timeout=60 to timeout=60.0 in simple-auth-client example - Change timeout=10 to timeout=10.0 in test_session_group.py
1 parent 9873cbf commit 161e513

File tree

4 files changed

+6
-7
lines changed

4 files changed

+6
-7
lines changed

examples/clients/simple-auth-client/mcp_simple_auth_client/main.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ async def _default_redirect_handler(authorization_url: str) -> None:
207207
async with sse_client(
208208
url=self.server_url,
209209
auth=oauth_auth,
210-
timeout=60,
210+
timeout=60.0,
211211
) as (read_stream, write_stream):
212212
await self._run_session(read_stream, write_stream, None)
213213
else:

src/mcp/client/session_group.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,8 +313,8 @@ async def _establish_session(
313313
httpx_client = create_mcp_http_client(
314314
headers=server_params.headers,
315315
timeout=httpx.Timeout(
316-
server_params.timeout.total_seconds(),
317-
read=server_params.sse_read_timeout.total_seconds(),
316+
server_params.timeout,
317+
read=server_params.sse_read_timeout,
318318
),
319319
)
320320
await session_stack.enter_async_context(httpx_client)

tests/client/test_session_group.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ async def test_disconnect_non_existent_server(self):
273273
"mcp.client.session_group.mcp.stdio_client",
274274
),
275275
(
276-
SseServerParameters(url="http://test.com/sse", timeout=10),
276+
SseServerParameters(url="http://test.com/sse", timeout=10.0),
277277
"sse",
278278
"mcp.client.session_group.sse_client",
279279
), # url, headers, timeout, sse_read_timeout

tests/shared/test_streamable_http.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import socket
1010
import time
1111
from collections.abc import Generator
12-
from datetime import timedelta
1312
from typing import Any
1413
from unittest.mock import MagicMock
1514

@@ -2370,8 +2369,8 @@ async def test_streamable_http_transport_deprecated_params_ignored(basic_server:
23702369
transport = StreamableHTTPTransport( # pyright: ignore[reportDeprecated]
23712370
url=f"{basic_server_url}/mcp",
23722371
headers={"X-Should-Be-Ignored": "ignored"},
2373-
timeout=999,
2374-
sse_read_timeout=timedelta(seconds=999),
2372+
timeout=999.0,
2373+
sse_read_timeout=999.0,
23752374
auth=None,
23762375
)
23772376

0 commit comments

Comments
 (0)