Skip to content

Commit 3c4f262

Browse files
committed
Fix ElicitRequestParams usage in task_session.py
Use ElicitRequestFormParams instead of the TypeAlias union type which cannot be instantiated directly.
1 parent 6e2b727 commit 3c4f262

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

src/mcp/server/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ async def handle_list_prompts(ctx: RequestContext) -> list[types.Prompt]:
4747

4848
import mcp.types as types
4949
from mcp.server.models import InitializationOptions
50-
from mcp.shared.experimental.tasks import TaskResultHandler
5150
from mcp.shared.exceptions import McpError
51+
from mcp.shared.experimental.tasks import TaskResultHandler
5252
from mcp.shared.message import ServerMessageMetadata, SessionMessage
5353
from mcp.shared.session import (
5454
BaseSession,

src/mcp/shared/experimental/tasks/task_session.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
CreateMessageResult,
2727
ElicitationCapability,
2828
ElicitRequestedSchema,
29-
ElicitRequestParams,
29+
ElicitRequestFormParams,
3030
ElicitResult,
3131
ErrorData,
3232
IncludeContext,
@@ -161,7 +161,8 @@ async def elicit(
161161
request_id = self._next_request_id()
162162

163163
# Build params with _meta containing related-task info
164-
params = ElicitRequestParams(
164+
# Use ElicitRequestFormParams (form mode) since we have message + requestedSchema
165+
params = ElicitRequestFormParams(
165166
message=message,
166167
requestedSchema=requestedSchema,
167168
)

src/mcp/types.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1721,6 +1721,7 @@ class CancelledNotification(Notification[CancelledNotificationParams, Literal["n
17211721
method: Literal["notifications/cancelled"] = "notifications/cancelled"
17221722
params: CancelledNotificationParams
17231723

1724+
17241725
class ElicitCompleteNotificationParams(NotificationParams):
17251726
"""Parameters for elicitation completion notifications."""
17261727

@@ -1924,7 +1925,7 @@ class ServerRequest(RootModel[ServerRequestType]):
19241925
| ToolListChangedNotification
19251926
| PromptListChangedNotification
19261927
| ElicitCompleteNotification
1927-
| TaskStatusNotification
1928+
| TaskStatusNotification
19281929
)
19291930

19301931

0 commit comments

Comments
 (0)