Skip to content

Commit 40028da

Browse files
committed
Remove None as valid return type from join_call_tool, fix typo ImMemory -> InMemory
1 parent 288ebe3 commit 40028da

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

src/mcp/client/session.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -329,7 +329,7 @@ async def join_call_tool(
329329
progress_callback: ProgressFnT | None = None,
330330
request_read_timeout_seconds: timedelta | None = None,
331331
done_on_timeout: bool = True,
332-
) -> types.CallToolResult | None:
332+
) -> types.CallToolResult:
333333
resume_token = self._request_state_manager.get_resume_token(request_id)
334334
metadata = ClientMessageMetadata(resumption_token=resume_token)
335335

src/mcp/shared/session.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ async def close_request(self, request_id: RequestId) -> bool: ...
194194
async def close(self) -> None: ...
195195

196196

197-
class ImMemoryRequestStateManager(
197+
class InMemoryRequestStateManager(
198198
RequestStateManager[
199199
SendRequestT,
200200
SendResultT,
@@ -354,7 +354,7 @@ def __init__(
354354
self._session_read_timeout_seconds = read_timeout_seconds
355355
self._exit_stack = AsyncExitStack()
356356
self._in_flight = {}
357-
self._request_state_manager = request_state_manager or ImMemoryRequestStateManager()
357+
self._request_state_manager = request_state_manager or InMemoryRequestStateManager()
358358

359359
async def __aenter__(self) -> Self:
360360
self._task_group = anyio.create_task_group()

tests/client/test_resource_cleanup.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
import anyio
44
import pytest
55

6-
from mcp.shared.session import BaseSession, ImMemoryRequestStateManager
6+
from mcp.shared.session import BaseSession, InMemoryRequestStateManager
77
from mcp.types import (
88
ClientRequest,
99
EmptyResult,
@@ -28,7 +28,7 @@ async def _send_response(self, request_id, response):
2828
write_stream_send, write_stream_receive = anyio.create_memory_object_stream(1)
2929
read_stream_send, read_stream_receive = anyio.create_memory_object_stream(1)
3030

31-
request_io_manager = ImMemoryRequestStateManager()
31+
request_io_manager = InMemoryRequestStateManager()
3232
# Create the session
3333
session = TestSession(
3434
read_stream_receive,

tests/client/test_session.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from mcp.shared.context import RequestContext
1111
from mcp.shared.exceptions import McpError
1212
from mcp.shared.message import SessionMessage
13-
from mcp.shared.session import ImMemoryRequestStateManager, RequestResponder
13+
from mcp.shared.session import InMemoryRequestStateManager, RequestResponder
1414
from mcp.shared.version import SUPPORTED_PROTOCOL_VERSIONS
1515
from mcp.types import (
1616
LATEST_PROTOCOL_VERSION,
@@ -973,8 +973,8 @@ async def message_handler(
973973
if isinstance(message, Exception):
974974
raise message
975975

976-
request_state_manager_1 = ImMemoryRequestStateManager()
977-
request_state_manager_2 = ImMemoryRequestStateManager()
976+
request_state_manager_1 = InMemoryRequestStateManager()
977+
request_state_manager_2 = InMemoryRequestStateManager()
978978

979979
async with (
980980
ClientSession(

0 commit comments

Comments
 (0)