|
| 1 | +"""Test for issue #1283 - Memory leak from idle sessions never being cleaned up. |
| 2 | +
|
| 3 | +Without an idle timeout mechanism, sessions created via StreamableHTTPSessionManager |
| 4 | +persist indefinitely in ``_server_instances`` even after the client disconnects. |
| 5 | +Over time this leaks memory. |
| 6 | +
|
| 7 | +The ``session_idle_timeout`` parameter on ``StreamableHTTPSessionManager`` allows |
| 8 | +the manager to automatically terminate and remove sessions that have been idle for |
| 9 | +longer than the configured duration. |
| 10 | +""" |
| 11 | + |
| 12 | +import time |
| 13 | +from collections.abc import Callable, Coroutine |
| 14 | +from typing import Any |
| 15 | + |
| 16 | +import anyio |
| 17 | +import pytest |
| 18 | +from starlette.types import Message, Scope |
| 19 | + |
| 20 | +from mcp.server.lowlevel import Server |
| 21 | +from mcp.server.streamable_http import MCP_SESSION_ID_HEADER, StreamableHTTPServerTransport |
| 22 | +from mcp.server.streamable_http_manager import StreamableHTTPSessionManager |
| 23 | + |
| 24 | + |
| 25 | +def _make_scope() -> Scope: |
| 26 | + return { |
| 27 | + "type": "http", |
| 28 | + "method": "POST", |
| 29 | + "path": "/mcp", |
| 30 | + "headers": [(b"content-type", b"application/json")], |
| 31 | + } |
| 32 | + |
| 33 | + |
| 34 | +async def _mock_receive() -> Message: # pragma: no cover |
| 35 | + return {"type": "http.request", "body": b"", "more_body": False} |
| 36 | + |
| 37 | + |
| 38 | +def _make_send(sent: list[Message]) -> Callable[[Message], Coroutine[Any, Any, None]]: |
| 39 | + async def mock_send(message: Message) -> None: |
| 40 | + sent.append(message) |
| 41 | + |
| 42 | + return mock_send |
| 43 | + |
| 44 | + |
| 45 | +def _extract_session_id(sent_messages: list[Message]) -> str: |
| 46 | + for msg in sent_messages: |
| 47 | + if msg["type"] == "http.response.start": # pragma: no branch |
| 48 | + for name, value in msg.get("headers", []): # pragma: no branch |
| 49 | + if name.decode().lower() == MCP_SESSION_ID_HEADER.lower(): # pragma: no branch |
| 50 | + return value.decode() |
| 51 | + raise AssertionError("Session ID not found in response headers") # pragma: no cover |
| 52 | + |
| 53 | + |
| 54 | +@pytest.mark.anyio |
| 55 | +async def test_idle_session_is_reaped(): |
| 56 | + """Session should be removed from _server_instances after idle timeout.""" |
| 57 | + app = Server("test-idle-reap") |
| 58 | + manager = StreamableHTTPSessionManager(app=app, session_idle_timeout=0.15) |
| 59 | + |
| 60 | + async with manager.run(): |
| 61 | + sent: list[Message] = [] |
| 62 | + await manager.handle_request(_make_scope(), _mock_receive, _make_send(sent)) |
| 63 | + session_id = _extract_session_id(sent) |
| 64 | + |
| 65 | + assert session_id in manager._server_instances |
| 66 | + |
| 67 | + # Wait for the cancel scope deadline to fire |
| 68 | + await anyio.sleep(0.4) |
| 69 | + |
| 70 | + assert session_id not in manager._server_instances |
| 71 | + |
| 72 | + |
| 73 | +@pytest.mark.anyio |
| 74 | +async def test_activity_resets_idle_timer(): |
| 75 | + """Requests during the timeout window should prevent the session from being reaped.""" |
| 76 | + app = Server("test-idle-reset") |
| 77 | + manager = StreamableHTTPSessionManager(app=app, session_idle_timeout=0.3) |
| 78 | + |
| 79 | + async with manager.run(): |
| 80 | + sent: list[Message] = [] |
| 81 | + await manager.handle_request(_make_scope(), _mock_receive, _make_send(sent)) |
| 82 | + session_id = _extract_session_id(sent) |
| 83 | + |
| 84 | + # Simulate ongoing activity by pushing back the idle scope deadline |
| 85 | + transport = manager._server_instances[session_id] |
| 86 | + assert transport.idle_scope is not None |
| 87 | + for _ in range(4): |
| 88 | + await anyio.sleep(0.1) |
| 89 | + transport.idle_scope.deadline = anyio.current_time() + 0.3 |
| 90 | + |
| 91 | + # Session should still be alive because we kept it active |
| 92 | + assert session_id in manager._server_instances |
| 93 | + |
| 94 | + # Now stop activity and let the timeout expire |
| 95 | + await anyio.sleep(0.6) |
| 96 | + |
| 97 | + assert session_id not in manager._server_instances |
| 98 | + |
| 99 | + |
| 100 | +@pytest.mark.anyio |
| 101 | +async def test_multiple_sessions_reaped_independently(): |
| 102 | + """Each session tracks its own idle timeout independently.""" |
| 103 | + app = Server("test-multi-idle") |
| 104 | + manager = StreamableHTTPSessionManager(app=app, session_idle_timeout=0.15) |
| 105 | + |
| 106 | + async with manager.run(): |
| 107 | + sent1: list[Message] = [] |
| 108 | + await manager.handle_request(_make_scope(), _mock_receive, _make_send(sent1)) |
| 109 | + session_id_1 = _extract_session_id(sent1) |
| 110 | + |
| 111 | + await anyio.sleep(0.05) |
| 112 | + sent2: list[Message] = [] |
| 113 | + await manager.handle_request(_make_scope(), _mock_receive, _make_send(sent2)) |
| 114 | + session_id_2 = _extract_session_id(sent2) |
| 115 | + |
| 116 | + assert session_id_1 in manager._server_instances |
| 117 | + assert session_id_2 in manager._server_instances |
| 118 | + |
| 119 | + # After enough time, both should be reaped |
| 120 | + await anyio.sleep(0.4) |
| 121 | + |
| 122 | + assert session_id_1 not in manager._server_instances |
| 123 | + assert session_id_2 not in manager._server_instances |
| 124 | + |
| 125 | + |
| 126 | +def test_session_idle_timeout_rejects_negative(): |
| 127 | + """session_idle_timeout must be a positive number.""" |
| 128 | + with pytest.raises(ValueError, match="positive number"): |
| 129 | + StreamableHTTPSessionManager(app=Server("test"), session_idle_timeout=-1) |
| 130 | + |
| 131 | + |
| 132 | +def test_session_idle_timeout_rejects_zero(): |
| 133 | + """session_idle_timeout must be a positive number.""" |
| 134 | + with pytest.raises(ValueError, match="positive number"): |
| 135 | + StreamableHTTPSessionManager(app=Server("test"), session_idle_timeout=0) |
| 136 | + |
| 137 | + |
| 138 | +def test_session_idle_timeout_rejects_stateless(): |
| 139 | + """session_idle_timeout is not supported in stateless mode.""" |
| 140 | + with pytest.raises(ValueError, match="not supported in stateless"): |
| 141 | + StreamableHTTPSessionManager(app=Server("test"), session_idle_timeout=30, stateless=True) |
| 142 | + |
| 143 | + |
| 144 | +@pytest.mark.anyio |
| 145 | +async def test_terminate_idempotency(): |
| 146 | + """Calling terminate() multiple times should be safe.""" |
| 147 | + transport = StreamableHTTPServerTransport(mcp_session_id="test-idempotent") |
| 148 | + |
| 149 | + async with transport.connect(): |
| 150 | + await transport.terminate() |
| 151 | + assert transport.is_terminated |
| 152 | + |
| 153 | + # Second call should be a no-op (no exception) |
| 154 | + await transport.terminate() |
| 155 | + assert transport.is_terminated |
| 156 | + |
| 157 | + |
| 158 | +@pytest.mark.anyio |
| 159 | +async def test_no_idle_timeout_sessions_persist(): |
| 160 | + """When session_idle_timeout is None (default), sessions persist indefinitely.""" |
| 161 | + app = Server("test-no-timeout") |
| 162 | + manager = StreamableHTTPSessionManager(app=app) |
| 163 | + |
| 164 | + async with manager.run(): |
| 165 | + sent: list[Message] = [] |
| 166 | + await manager.handle_request(_make_scope(), _mock_receive, _make_send(sent)) |
| 167 | + session_id = _extract_session_id(sent) |
| 168 | + |
| 169 | + await anyio.sleep(0.3) |
| 170 | + assert session_id in manager._server_instances |
| 171 | + |
| 172 | + |
| 173 | +@pytest.mark.anyio |
| 174 | +async def test_run_server_exits_promptly_after_idle_timeout(): |
| 175 | + """The run_server task must exit shortly after the idle timeout fires.""" |
| 176 | + app = Server("test-lifecycle") |
| 177 | + |
| 178 | + task_exited = anyio.Event() |
| 179 | + exit_timestamp: list[float] = [] |
| 180 | + original_run = app.run |
| 181 | + |
| 182 | + async def instrumented_run(*args: Any, **kwargs: Any) -> None: |
| 183 | + try: |
| 184 | + await original_run(*args, **kwargs) |
| 185 | + finally: |
| 186 | + exit_timestamp.append(time.monotonic()) |
| 187 | + task_exited.set() |
| 188 | + |
| 189 | + app.run = instrumented_run # type: ignore[assignment] |
| 190 | + |
| 191 | + idle_timeout = 0.5 |
| 192 | + manager = StreamableHTTPSessionManager(app=app, session_idle_timeout=idle_timeout) |
| 193 | + |
| 194 | + async with manager.run(): |
| 195 | + sent: list[Message] = [] |
| 196 | + await manager.handle_request(_make_scope(), _mock_receive, _make_send(sent)) |
| 197 | + session_id = _extract_session_id(sent) |
| 198 | + assert session_id in manager._server_instances |
| 199 | + |
| 200 | + pre_reap_time = time.monotonic() |
| 201 | + |
| 202 | + with anyio.fail_after(idle_timeout * 4): |
| 203 | + await task_exited.wait() |
| 204 | + |
| 205 | + assert len(exit_timestamp) == 1 |
| 206 | + total_elapsed = exit_timestamp[0] - pre_reap_time |
| 207 | + assert total_elapsed < idle_timeout * 3, ( |
| 208 | + f"run_server task took {total_elapsed:.3f}s to exit; expected < {idle_timeout * 3:.1f}s" |
| 209 | + ) |
| 210 | + assert session_id not in manager._server_instances |
| 211 | + |
| 212 | + |
| 213 | +@pytest.mark.anyio |
| 214 | +async def test_run_server_finally_block_runs_after_terminate(): |
| 215 | + """Verify that the finally block in run_server executes after terminate().""" |
| 216 | + app = Server("test-finally") |
| 217 | + |
| 218 | + lifecycle_events: list[str] = [] |
| 219 | + original_run = app.run |
| 220 | + |
| 221 | + async def instrumented_run(*args: Any, **kwargs: Any) -> None: |
| 222 | + lifecycle_events.append("run_entered") |
| 223 | + try: |
| 224 | + await original_run(*args, **kwargs) |
| 225 | + finally: |
| 226 | + lifecycle_events.append("run_exited") |
| 227 | + |
| 228 | + app.run = instrumented_run # type: ignore[assignment] |
| 229 | + |
| 230 | + manager = StreamableHTTPSessionManager(app=app) |
| 231 | + |
| 232 | + async with manager.run(): |
| 233 | + sent: list[Message] = [] |
| 234 | + await manager.handle_request(_make_scope(), _mock_receive, _make_send(sent)) |
| 235 | + session_id = _extract_session_id(sent) |
| 236 | + transport = manager._server_instances[session_id] |
| 237 | + |
| 238 | + assert "run_entered" in lifecycle_events |
| 239 | + assert "run_exited" not in lifecycle_events |
| 240 | + |
| 241 | + await transport.terminate() |
| 242 | + |
| 243 | + with anyio.fail_after(3.0): |
| 244 | + while "run_exited" not in lifecycle_events: |
| 245 | + await anyio.sleep(0.01) |
| 246 | + |
| 247 | + assert "run_exited" in lifecycle_events |
| 248 | + |
| 249 | + |
| 250 | +@pytest.mark.anyio |
| 251 | +async def test_idle_timeout_end_to_end(): |
| 252 | + """End-to-end: idle timeout causes session cleanup with a real Server.""" |
| 253 | + app = Server("test-e2e") |
| 254 | + idle_timeout = 0.3 |
| 255 | + manager = StreamableHTTPSessionManager(app=app, session_idle_timeout=idle_timeout) |
| 256 | + |
| 257 | + async with manager.run(): |
| 258 | + sent: list[Message] = [] |
| 259 | + await manager.handle_request(_make_scope(), _mock_receive, _make_send(sent)) |
| 260 | + session_id = _extract_session_id(sent) |
| 261 | + assert session_id in manager._server_instances |
| 262 | + |
| 263 | + with anyio.fail_after(idle_timeout + 1.0): |
| 264 | + while session_id in manager._server_instances: |
| 265 | + await anyio.sleep(0.05) |
| 266 | + |
| 267 | + assert session_id not in manager._server_instances |
0 commit comments