Commit 9c0b2c5
committed
Revert FallbackProcess to synchronous termination approach
This reverts the FallbackProcess termination logic to use synchronous
wait in a thread rather than async polling. The previous async polling
approach with anyio.sleep(0.1) may have been causing resource cleanup
issues in Windows CI with Python 3.10.
The synchronous approach:
- Uses to_thread.run_sync() to wait for process termination
- Removes the timeout-based termination attempt
- Simplifies the wait() method to directly use popen.wait()
This should resolve the unclosed transport warnings seen in CI tests.1 parent a675bd5 commit 9c0b2c5
1 file changed
+6
-20
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
| 11 | + | |
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| |||
74 | 74 | | |
75 | 75 | | |
76 | 76 | | |
77 | | - | |
78 | | - | |
79 | | - | |
80 | | - | |
81 | | - | |
82 | | - | |
83 | | - | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
89 | 80 | | |
90 | 81 | | |
91 | 82 | | |
| |||
100 | 91 | | |
101 | 92 | | |
102 | 93 | | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | | - | |
109 | | - | |
| 94 | + | |
| 95 | + | |
110 | 96 | | |
111 | 97 | | |
112 | 98 | | |
| |||
0 commit comments