address review

Author: blink1073

packages/mongodb-runner/src/mongocluster.ts

@@ -534,27 +534,7 @@ export class MongoCluster extends EventEmitter<MongoClusterEvents> {
     }
 
     await cluster.addAuthIfNeeded();
-
-    // Set up requireApiVersion if requested.
-    if (options.requireApiVersion !== undefined) {
-      if (options.topology === 'replset') {
-        throw new Error(
-          'requireApiVersion is not supported for replica sets, see SERVER-97010',
-        );
-      }
-      await Promise.all(
-        [...cluster.servers].map(
-          async (child) =>
-            await child.withClient(async (client) => {
-              const admin = client.db('admin');
-              await admin.command({ setParameter: 1, requireApiVersion: true });
-            }),
-        ),
-      );
-      await cluster.updateDefaultConnectionOptions({
-        serverApi: String(options.requireApiVersion) as '1',
-      });
-    }
+    await cluster.addRequireApiVersionIfNeeded(options);
     return cluster;
   }
 
@@ -563,6 +543,32 @@ export class MongoCluster extends EventEmitter<MongoClusterEvents> {
     yield* this.shards;
   }
 
+  async addRequireApiVersionIfNeeded({
+    ...options
+  }: MongoClusterOptions): Promise<void> {
+    // Set up requireApiVersion if requested.
+    if (options.requireApiVersion !== undefined) {
+      return;
+    }
+    if (options.topology === 'replset') {
+      throw new Error(
+        'requireApiVersion is not supported for replica sets, see SERVER-97010',
+      );
+    }
+    await Promise.all(
+      [...this.servers].map(
+        async (child) =>
+          await child.withClient(async (client) => {
+            const admin = client.db('admin');
+            await admin.command({ setParameter: 1, requireApiVersion: true });
+          }),
+      ),
+    );
+    await this.updateDefaultConnectionOptions({
+      serverApi: String(options.requireApiVersion) as '1',
+    });
+  }
+
   async addAuthIfNeeded(): Promise<void> {
     if (!this.users?.length) return;
     // Sleep to give time for a possible replset election to settle.

packages/mongodb-runner/src/mongoserver.ts

@@ -287,6 +287,8 @@ export class MongoServer extends EventEmitter<MongoServerEvents> {
       logEntryStream.resume();
 
       srv.port = port;
+      // If a keyFile is present, we cannot read or write on the server until
+      // a user is added to the primary.
       if (!options.args?.includes('--keyFile')) {
         const buildInfoError = await srv._populateBuildInfo('insert-new');
         if (buildInfoError) {
@@ -340,8 +342,8 @@ export class MongoServer extends EventEmitter<MongoServerEvents> {
           if (status.authInfo.authenticatedUsers.length > 0) {
             return true;
           }
-          // If the server does not support auth, just get the build info without
-          // setting the metadata.
+          // The server is most likely an arbiter, which does not support
+          // authenticated users but does support getting the buildInfo.
           debug('Server does not support authorization', this.port);
           this.buildInfo = await client.db('admin').command({ buildInfo: 1 });
           return false;