Change createDeployment to return created deployment name

Author: Luke-Sanderson

package.json

@@ -121,7 +121,7 @@
     "node": "^20.19.0 || ^22.12.0 || >= 23.0.0"
   },
   "optionalDependencies": {
-    "@mongodb-js-preview/atlas-local": "^0.0.0-preview.2",
+    "@mongodb-js-preview/atlas-local": "^0.0.0-preview.3",
     "kerberos": "^2.2.2"
   }
 }

src/tools/atlasLocal/create/createDeployment.ts

@@ -24,15 +24,15 @@ export class CreateDeploymentTool extends AtlasLocalToolBase {
             },
         };
         // Create the deployment
-        await client.createDeployment(deploymentOptions);
+        const deployment = await client.createDeployment(deploymentOptions);
 
-        if (deploymentName) {
-            return {
-                content: [{ type: "text", text: `Deployment "${deploymentName}" created.` }],
-            };
-        }
         return {
-            content: [{ type: "text", text: `Deployment created.` }],
+            content: [
+                {
+                    type: "text",
+                    text: `Deployment with container ID "${deployment.containerId}" and name "${deployment.name}" created.`,
+                },
+            ],
         };
     }
 }

tests/integration/tools/atlas-local/createDeployment.test.ts

@@ -125,11 +125,16 @@ describe("atlas-local-create-deployment", () => {
         // Create a deployment
         const deploymentName = `test-deployment-${Date.now()}`;
         deploymentNamesToCleanup.push(deploymentName);
-        await integration.mcpClient().callTool({
+        const createResponse = await integration.mcpClient().callTool({
             name: "atlas-local-create-deployment",
             arguments: { deploymentName },
         });
 
+        // Check the response contains the deployment name
+        const createElements = getResponseElements(createResponse.content);
+        expect(createElements.length).toBeGreaterThanOrEqual(1);
+        expect(createElements[0]?.text).toContain(deploymentName);
+
         // List the deployments
         const response = await integration.mcpClient().callTool({
             name: "atlas-local-list-deployments",
@@ -146,11 +151,21 @@ describe("atlas-local-create-deployment", () => {
         await waitUntilMcpClientIsSet(integration.mcpServer(), signal);
 
         // Create a deployment
-        await integration.mcpClient().callTool({
+        const createResponse = await integration.mcpClient().callTool({
             name: "atlas-local-create-deployment",
             arguments: {},
         });
 
+        // Check the response contains the deployment name
+        const createElements = getResponseElements(createResponse.content);
+        expect(createElements.length).toBeGreaterThanOrEqual(1);
+
+        // Extract the deployment name from the response
+        // The name should be in the format local<number>
+        const deploymentName = createElements[0]?.text.match(/local\d+/)?.[0];
+        expectDefined(deploymentName);
+        deploymentNamesToCleanup.push(deploymentName);
+
         // List the deployments
         const response = await integration.mcpClient().callTool({
             name: "atlas-local-list-deployments",
@@ -160,11 +175,7 @@ describe("atlas-local-create-deployment", () => {
         // Check the deployment has been created
         const elements = getResponseElements(response.content);
         expect(elements.length).toBeGreaterThanOrEqual(1);
-
-        // Random name starts with local and a number
-        const deploymentName = elements[1]?.text.match(/local\d+/)?.[0];
-        expectDefined(deploymentName);
-        deploymentNamesToCleanup.push(deploymentName);
+        expect(elements[1]?.text ?? "").toContain(deploymentName);
         expect(elements[1]?.text ?? "").toContain("Running");
     });
 });