chore: use ListCollectionsTool response creators in tests

Author: himanshusinghs

src/tools/mongodb/metadata/listCollections.ts

@@ -2,6 +2,28 @@ import { CallToolResult } from "@modelcontextprotocol/sdk/types.js";
 import { DbOperationArgs, MongoDBToolBase } from "../mongodbTool.js";
 import { ToolArgs, OperationType } from "../../tool.js";
 
+export function listCollectionsResponse(database: string, collections: string[]): CallToolResult {
+    if (collections.length === 0) {
+        return {
+            content: [
+                {
+                    type: "text",
+                    text: `No collections found for database "${database}". To create a collection, use the "create-collection" tool.`,
+                },
+            ],
+        };
+    }
+
+    return {
+        content: collections.map((collection) => {
+            return {
+                text: `Name: "${collection}"`,
+                type: "text",
+            };
+        }),
+    };
+}
+
 export class ListCollectionsTool extends MongoDBToolBase {
     protected name = "list-collections";
     protected description = "List all collections for a given database";
@@ -15,24 +37,9 @@ export class ListCollectionsTool extends MongoDBToolBase {
         const provider = await this.ensureConnected();
         const collections = await provider.listCollections(database);
 
-        if (collections.length === 0) {
-            return {
-                content: [
-                    {
-                        type: "text",
-                        text: `No collections found for database "${database}". To create a collection, use the "create-collection" tool.`,
-                    },
-                ],
-            };
-        }
-
-        return {
-            content: collections.map((collection) => {
-                return {
-                    text: `Name: "${collection.name}"`,
-                    type: "text",
-                };
-            }),
-        };
+        return listCollectionsResponse(
+            database,
+            collections.map((collection) => `${collection.name}`)
+        );
     }
 }

tests/accuracy/list-collections.test.ts

@@ -1,25 +1,16 @@
 import { describeAccuracyTests } from "./sdk/describe-accuracy-tests.js";
 import { getAvailableModels } from "./sdk/models.js";
 import { AccuracyTestConfig } from "./sdk/describe-accuracy-tests.js";
+import { listCollectionsResponse } from "../../src/tools/mongodb/metadata/listCollections.js";
+import { listDatabasesResponse } from "../../src/tools/mongodb/metadata/listDatabases.js";
 
-function describeListCollectionsAccuracyTests(prompt: string): AccuracyTestConfig {
+function callsListCollections(prompt: string): AccuracyTestConfig {
     return {
         injectConnectedAssumption: true,
         prompt: prompt,
         mockedTools: {
             "list-collections": function listCollections() {
-                return {
-                    content: [
-                        {
-                            type: "text",
-                            text: "Name: coll1",
-                        },
-                        {
-                            type: "text",
-                            text: "Name: coll1",
-                        },
-                    ],
-                };
+                return listCollectionsResponse("db1", ["coll1", "coll2"]);
             },
         },
         expectedToolCalls: [
@@ -31,8 +22,47 @@ function describeListCollectionsAccuracyTests(prompt: string): AccuracyTestConfi
     };
 }
 
+function callsListDatabasesAndListCollections(prompt: string): AccuracyTestConfig {
+    return {
+        injectConnectedAssumption: true,
+        prompt: prompt,
+        mockedTools: {
+            "list-collections": function listCollections() {
+                return listCollectionsResponse("db1", ["coll1", "coll2"]);
+            },
+            "list-databases": function listDatabases() {
+                return listDatabasesResponse([
+                    {
+                        name: "db1",
+                        sizeOnDisk: "1024",
+                    },
+                    {
+                        name: "db2",
+                        sizeOnDisk: "2048",
+                    },
+                ]);
+            },
+        },
+        expectedToolCalls: [
+            {
+                toolName: "list-databases",
+                parameters: {},
+            },
+            {
+                toolName: "list-collections",
+                parameters: { database: "db1" },
+            },
+            {
+                toolName: "list-collections",
+                parameters: { database: "db2" },
+            },
+        ],
+    };
+}
+
 describeAccuracyTests("list-collections", getAvailableModels(), [
-    describeListCollectionsAccuracyTests("How many collections do I have in database db1?"),
-    describeListCollectionsAccuracyTests("List all the collections in my MongoDB database db1."),
-    describeListCollectionsAccuracyTests("Is there a coll1 collection in my MongoDB database db1?"),
+    callsListCollections("How many collections do I have in database db1?"),
+    callsListCollections("List all the collections in my MongoDB database db1."),
+    callsListCollections("Is there a coll1 collection in my MongoDB database db1?"),
+    callsListDatabasesAndListCollections("List all the collections that I have in total on my cluster?"),
 ]);