fix: error handling

Author: fmenezes

README.md

@@ -174,6 +174,7 @@ The MongoDB MCP Server can be configured using multiple methods, with the follow
 To use the Atlas API tools, you'll need to create a service account in MongoDB Atlas:
 
 1. **Create a Service Account:**
+
    - Log in to MongoDB Atlas at [cloud.mongodb.com](https://cloud.mongodb.com)
    - Navigate to Access Manager > Organization Access
    - Click Add New > Applications > Service Accounts
@@ -182,10 +183,12 @@ To use the Atlas API tools, you'll need to create a service account in MongoDB A
    - Click "Create"
 
 2. **Save Client Credentials:**
+
    - After creation, you'll be shown the Client ID and Client Secret
    - **Important:** Copy and save the Client Secret immediately as it won't be displayed again
 
 3. **Add Access List Entry (Optional but recommended):**
+
    - Add your IP address to the API access list
 
 4. **Configure the MCP Server:**

src/tools/mongodb/mongodbTool.ts

@@ -28,7 +28,7 @@ export abstract class MongoDBToolBase extends ToolBase {
         return provider;
     }
 
-    protected handleError(error: unknown): CallToolResult | undefined {
+    protected handleError(error: unknown): Promise<CallToolResult> | CallToolResult {
         if (error instanceof MongoDBError && error.code === ErrorCodes.NotConnectedToMongoDB) {
             return {
                 content: [
@@ -41,9 +41,10 @@ export abstract class MongoDBToolBase extends ToolBase {
                         text: "Please use the 'connect' tool to connect to a MongoDB instance.",
                     },
                 ],
+                isError: true,
             };
         }
 
-        return undefined;
+        return super.handleError(error);
     }
 }

src/tools/tool.ts

@@ -32,30 +32,7 @@ export abstract class ToolBase {
             } catch (error) {
                 logger.error(mongoLogId(1_000_000), "tool", `Error executing ${this.name}: ${error}`);
 
-                // If the error is authentication related, suggest using auth tool
-                if (error instanceof Error && error.message.includes("Not authenticated")) {
-                    return {
-                        content: [
-                            { type: "text", text: "You need to authenticate before accessing Atlas data." },
-                            {
-                                type: "text",
-                                text: "Please use the 'auth' tool to log in to your MongoDB Atlas account.",
-                            },
-                        ],
-                    };
-                }
-
-                return (
-                    this.handleError(error) || {
-                        content: [
-                            {
-                                type: "text",
-                                text: `Error running ${this.name}: ${error instanceof Error ? error.message : String(error)}`,
-                            },
-                        ],
-                        isError: true,
-                    }
-                );
+                return await this.handleError(error);
             }
         };
 
@@ -70,8 +47,15 @@ export abstract class ToolBase {
     }
 
     // This method is intended to be overridden by subclasses to handle errors
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    protected handleError(error: unknown): CallToolResult | undefined {
-        return undefined;
+    protected handleError(error: unknown): Promise<CallToolResult> | CallToolResult {
+        return {
+            content: [
+                {
+                    type: "text",
+                    text: `Error running ${this.name}: ${error instanceof Error ? error.message : String(error)}`,
+                },
+            ],
+            isError: true,
+        };
     }
 }