address comment: move objectId to common args

Author: blva

src/tools/args.ts

@@ -18,19 +18,19 @@ export const ALLOWED_PROJECT_NAME_CHARACTERS_ERROR =
     "Project names can't be longer than 64 characters and can only contain letters, numbers, spaces, and the following symbols: ( ) @ & + : . _ - ' ,";
 export const CommonArgs = {
     string: (): ZodString => z.string().regex(NO_UNICODE_REGEX, NO_UNICODE_ERROR),
-};
 
-export const AtlasArgs = {
     objectId: (fieldName: string): z.ZodString =>
         z
             .string()
             .min(1, `${fieldName} is required`)
             .length(24, `${fieldName} must be exactly 24 characters`)
             .regex(/^[0-9a-fA-F]+$/, `${fieldName} must contain only hexadecimal characters`),
+};
 
-    projectId: (): z.ZodString => AtlasArgs.objectId("projectId"),
+export const AtlasArgs = {
+    projectId: (): z.ZodString => CommonArgs.objectId("projectId"),
 
-    organizationId: (): z.ZodString => AtlasArgs.objectId("organizationId"),
+    organizationId: (): z.ZodString => CommonArgs.objectId("organizationId"),
 
     clusterName: (): z.ZodString =>
         z

tests/unit/args.test.ts

@@ -54,18 +54,16 @@ describe("Tool args", () => {
                 expect(() => schema.parse({})).toThrow();
             });
         });
-    });
 
-    describe("AtlasArgs", () => {
         describe("objectId", () => {
             it("should validate 24-character hexadecimal strings", () => {
-                const schema = AtlasArgs.objectId("Test ID");
+                const schema = CommonArgs.objectId("Test ID");
                 const validId = "507f1f77bcf86cd799439011";
                 expect(schema.parse(validId)).toBe(validId);
             });
 
             it("should reject invalid ObjectId formats", () => {
-                const schema = AtlasArgs.objectId("Test ID");
+                const schema = CommonArgs.objectId("Test ID");
 
                 // Too short
                 expect(() => schema.parse("507f1f77bcf86cd79943901")).toThrow();
@@ -82,21 +80,23 @@ describe("Tool args", () => {
             });
 
             it("should provide custom field name in error messages", () => {
-                const schema = AtlasArgs.objectId("Custom Field");
+                const schema = CommonArgs.objectId("Custom Field");
                 expect(() => schema.parse("invalid")).toThrow("Custom Field must be exactly 24 characters");
             });
 
             it("should not fail if the value is optional", () => {
-                const schema = AtlasArgs.objectId("Custom Field").optional();
+                const schema = CommonArgs.objectId("Custom Field").optional();
                 expect(schema.parse(undefined)).toBeUndefined();
             });
 
             it("should not fail if the value is empty", () => {
-                const schema = AtlasArgs.objectId("Custom Field");
+                const schema = CommonArgs.objectId("Custom Field");
                 expect(() => schema.parse(undefined)).toThrow("Required");
             });
         });
+    });
 
+    describe("AtlasArgs", () => {
         describe("projectId", () => {
             it("should validate project IDs", () => {
                 const schema = AtlasArgs.projectId();