Skip to content

Commit 8ac8ef3

Browse files
committed
chore: rename
1 parent dd6dadd commit 8ac8ef3

File tree

3 files changed

+13
-13
lines changed

3 files changed

+13
-13
lines changed

src/telemetry/telemetry.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ export const DEVICE_ID_TIMEOUT = 3000;
1919
export class Telemetry {
2020
private isBufferingEvents: boolean = true;
2121
/** Resolves when the device ID is retrieved or timeout occurs */
22-
public dataPromise: Promise<[string, boolean]> | undefined;
22+
public setupPromise: Promise<[string, boolean]> | undefined;
2323
private deviceIdAbortController = new AbortController();
2424
private eventCache: EventCache;
2525
private getRawMachineId: () => Promise<string>;
@@ -49,7 +49,7 @@ export class Telemetry {
4949
): Telemetry {
5050
const instance = new Telemetry(session, userConfig, commonProperties, { eventCache, getRawMachineId });
5151

52-
void instance.start();
52+
void instance.setup();
5353
return instance;
5454
}
5555

@@ -76,11 +76,11 @@ export class Telemetry {
7676
return exists.includes(true);
7777
}
7878

79-
private async start(): Promise<void> {
79+
private async setup(): Promise<void> {
8080
if (!this.isTelemetryEnabled()) {
8181
return;
8282
}
83-
this.dataPromise = Promise.all([
83+
this.setupPromise = Promise.all([
8484
getDeviceId({
8585
getMachineId: () => this.getRawMachineId(),
8686
onError: (reason, error) => {
@@ -101,7 +101,7 @@ export class Telemetry {
101101
this.isContainerEnv(),
102102
]);
103103

104-
const [deviceId, containerEnv] = await this.dataPromise;
104+
const [deviceId, containerEnv] = await this.setupPromise;
105105

106106
this.commonProperties.device_id = deviceId;
107107
this.commonProperties.is_container_env = containerEnv;

tests/integration/telemetry.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ describe("Telemetry", () => {
2020
expect(telemetry.getCommonProperties().device_id).toBe(undefined);
2121
expect(telemetry["isBufferingEvents"]).toBe(true);
2222

23-
await telemetry.dataPromise;
23+
await telemetry.setupPromise;
2424

2525
expect(telemetry.getCommonProperties().device_id).toBe(actualHashedId);
2626
expect(telemetry["isBufferingEvents"]).toBe(false);

tests/unit/telemetry.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ describe("Telemetry", () => {
138138
it("should send events successfully", async () => {
139139
const testEvent = createTestEvent();
140140

141-
await telemetry.dataPromise;
141+
await telemetry.setupPromise;
142142

143143
await telemetry.emitEvents([testEvent]);
144144

@@ -154,7 +154,7 @@ describe("Telemetry", () => {
154154

155155
const testEvent = createTestEvent();
156156

157-
await telemetry.dataPromise;
157+
await telemetry.setupPromise;
158158

159159
await telemetry.emitEvents([testEvent]);
160160

@@ -179,7 +179,7 @@ describe("Telemetry", () => {
179179
// Set up mock to return cached events
180180
mockEventCache.getEvents.mockReturnValueOnce([cachedEvent]);
181181

182-
await telemetry.dataPromise;
182+
await telemetry.setupPromise;
183183

184184
await telemetry.emitEvents([newEvent]);
185185

@@ -191,7 +191,7 @@ describe("Telemetry", () => {
191191
});
192192

193193
it("should correctly add common properties to events", async () => {
194-
await telemetry.dataPromise;
194+
await telemetry.setupPromise;
195195

196196
const commonProps = telemetry.getCommonProperties();
197197

@@ -227,7 +227,7 @@ describe("Telemetry", () => {
227227
expect(telemetry["isBufferingEvents"]).toBe(true);
228228
expect(telemetry.getCommonProperties().device_id).toBe(undefined);
229229

230-
await telemetry.dataPromise;
230+
await telemetry.setupPromise;
231231

232232
expect(telemetry["isBufferingEvents"]).toBe(false);
233233
expect(telemetry.getCommonProperties().device_id).toBe(hashedMachineId);
@@ -243,7 +243,7 @@ describe("Telemetry", () => {
243243
expect(telemetry["isBufferingEvents"]).toBe(true);
244244
expect(telemetry.getCommonProperties().device_id).toBe(undefined);
245245

246-
await telemetry.dataPromise;
246+
await telemetry.setupPromise;
247247

248248
expect(telemetry["isBufferingEvents"]).toBe(false);
249249
expect(telemetry.getCommonProperties().device_id).toBe("unknown");
@@ -271,7 +271,7 @@ describe("Telemetry", () => {
271271

272272
jest.advanceTimersByTime(DEVICE_ID_TIMEOUT);
273273

274-
await telemetry.dataPromise;
274+
await telemetry.setupPromise;
275275

276276
expect(telemetry.getCommonProperties().device_id).toBe("unknown");
277277
expect(telemetry["isBufferingEvents"]).toBe(false);

0 commit comments

Comments
 (0)