address comments

Author: blva

src/common/atlas/roles.ts

@@ -1,32 +1,33 @@
 import type { UserConfig } from "../config.js";
 import type { DatabaseUserRole } from "./openapi.js";
 
+const readWriteRole: DatabaseUserRole = {
+    roleName: "readWriteAnyDatabase",
+    databaseName: "admin",
+};
+
+const readOnlyRole: DatabaseUserRole = {
+    roleName: "readAnyDatabase",
+    databaseName: "admin",
+};
+
 /**
  * Get the default role name for the database user based on the Atlas Admin API
  * https://www.mongodb.com/docs/atlas/mongodb-users-roles-and-privileges/
  */
 export function getDefaultRoleFromConfig(config: UserConfig): DatabaseUserRole {
     if (config.readOnly) {
-        return {
-            roleName: "readAnyDatabase",
-            databaseName: "admin",
-        };
+        return readOnlyRole;
     }
 
     // If any of the write tools are enabled, use readWriteAnyDatabase
     if (
-        !config.disabledTools?.includes("create") ||
-        !config.disabledTools?.includes("update") ||
-        !config.disabledTools?.includes("delete")
+        !config.disabledTools.includes("create") ||
+        !config.disabledTools.includes("update") ||
+        !config.disabledTools.includes("delete")
     ) {
-        return {
-            roleName: "readWriteAnyDatabase",
-            databaseName: "admin",
-        };
+        return readWriteRole;
     }
 
-    return {
-        roleName: "readAnyDatabase",
-        databaseName: "admin",
-    };
+    return readOnlyRole;
 }