fix: remove dep on export input for export name

With this commit we're removing the dependency on export tool input for
constructing the name of the export without affecting the user
experience in any way.

Author: himanshusinghs

src/common/exportsManager.ts

@@ -163,7 +163,7 @@ export class ExportsManager extends EventEmitter<ExportsManagerEvents> {
     }): Promise<AvailableExport> {
         try {
             this.assertIsNotShuttingDown();
-            const exportNameWithExtension = validateExportName(ensureExtension(exportName, "json"));
+            const exportNameWithExtension = ensureExtension(exportName, "json");
             if (this.storedExports[exportNameWithExtension]) {
                 return Promise.reject(
                     new Error("Export with same name is either already available or being generated.")
@@ -373,22 +373,6 @@ export function ensureExtension(pathOrName: string, extension: string): string {
     return `${pathOrName}${extWithDot}`;
 }
 
-/**
- * Small utility to decoding and validating provided export name for path
- * traversal or no extension */
-export function validateExportName(nameWithExtension: string): string {
-    const decodedName = decodeURIComponent(nameWithExtension);
-    if (!path.extname(decodedName)) {
-        throw new Error("Provided export name has no extension");
-    }
-
-    if (decodedName.includes("..") || decodedName.includes("/") || decodedName.includes("\\")) {
-        throw new Error("Invalid export name: path traversal hinted");
-    }
-
-    return decodedName;
-}
-
 export function isExportExpired(createdAt: number, exportTimeoutMs: number): boolean {
     return Date.now() - createdAt > exportTimeoutMs;
 }

src/resources/common/exportedData.ts

@@ -72,7 +72,7 @@ export class ExportedData {
     private autoCompleteExportName: CompleteResourceTemplateCallback = (value) => {
         try {
             return this.session.exportsManager.availableExports
-                .filter(({ exportName }) => exportName.startsWith(value))
+                .filter(({ exportName, exportTitle }) => exportName.startsWith(value) || exportTitle.includes(value))
                 .map(({ exportName }) => exportName);
         } catch (error) {
             this.session.logger.error({

src/tools/mongodb/read/export.ts

@@ -81,7 +81,7 @@ export class ExportTool extends MongoDBToolBase {
             });
         }
 
-        const exportName = `${database}.${collection}.${new ObjectId().toString()}.json`;
+        const exportName = `${new ObjectId().toString()}.json`;
 
         const { exportURI, exportPath } = await this.session.exportsManager.createJSONExport({
             input: cursor,

tests/integration/resources/exportedData.test.ts

@@ -155,10 +155,10 @@ describeWithMongoDB(
                     },
                     argument: {
                         name: "exportName",
-                        value: "b",
+                        value: "big",
                     },
                 });
-                expect(completeResponse.completion.total).toEqual(1);
+                expect(completeResponse.completion.total).toBeGreaterThanOrEqual(1);
             });
         });
     },

tests/unit/common/exportsManager.test.ts

@@ -5,12 +5,7 @@ import type { FindCursor } from "mongodb";
 import { Long } from "mongodb";
 import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
 import type { ExportsManagerConfig } from "../../../src/common/exportsManager.js";
-import {
-    ensureExtension,
-    isExportExpired,
-    ExportsManager,
-    validateExportName,
-} from "../../../src/common/exportsManager.js";
+import { ensureExtension, isExportExpired, ExportsManager } from "../../../src/common/exportsManager.js";
 import type { AvailableExport } from "../../../src/common/exportsManager.js";
 import { config } from "../../../src/common/config.js";
 import { ROOT_DIR } from "../../accuracy/sdk/constants.js";
@@ -611,16 +606,6 @@ describe("#ensureExtension", () => {
     });
 });
 
-describe("#validateExportName", () => {
-    it("should return decoded name when name is valid", () => {
-        expect(validateExportName(encodeURIComponent("Test Name.json"))).toEqual("Test Name.json");
-    });
-    it("should throw when name is invalid", () => {
-        expect(() => validateExportName("NoExtension")).toThrow("Provided export name has no extension");
-        expect(() => validateExportName("../something.json")).toThrow("Invalid export name: path traversal hinted");
-    });
-});
-
 describe("#isExportExpired", () => {
     it("should return true if export is expired", () => {
         const createdAt = Date.now() - 1000;