chore: allow having the atlas cluster info independently of the connection state

We used to support only having it when connected, but it might be
useful also when errored

Author: kmruiz

src/common/connectionManager.ts

@@ -26,12 +26,12 @@ export type ConnectionStringAuthType = "scram" | "ldap" | "kerberos" | OIDCConne
 export interface ConnectionState {
     tag: ConnectionTag;
     connectionStringAuthType?: ConnectionStringAuthType;
+    connectedAtlasCluster?: AtlasClusterConnectionInfo;
 }
 
 export interface ConnectionStateConnected extends ConnectionState {
     tag: "connected";
     serviceProvider: NodeDriverServiceProvider;
-    connectedAtlasCluster?: AtlasClusterConnectionInfo;
 }
 
 export interface ConnectionStateConnecting extends ConnectionState {
@@ -104,7 +104,11 @@ export class ConnectionManager extends EventEmitter<ConnectionManagerEvents> {
             });
         } catch (error: unknown) {
             const errorReason = error instanceof Error ? error.message : `${error as string}`;
-            this.changeState("connection-errored", { tag: "errored", errorReason });
+            this.changeState("connection-errored", {
+                tag: "errored",
+                errorReason,
+                connectedAtlasCluster: settings.atlas,
+            });
             throw new MongoDBError(ErrorCodes.MisconfiguredConnectionString, errorReason);
         }
 
@@ -119,7 +123,11 @@ export class ConnectionManager extends EventEmitter<ConnectionManagerEvents> {
             });
         } catch (error: unknown) {
             const errorReason = error instanceof Error ? error.message : `${error as string}`;
-            this.changeState("connection-errored", { tag: "errored", errorReason });
+            this.changeState("connection-errored", {
+                tag: "errored",
+                errorReason,
+                connectedAtlasCluster: settings.atlas,
+            });
             throw new MongoDBError(ErrorCodes.NotConnectedToMongoDB, errorReason);
         }
     }

src/common/session.ts

@@ -125,11 +125,6 @@ export class Session extends EventEmitter<SessionEvents> {
     }
 
     get connectedAtlasCluster(): AtlasClusterConnectionInfo | undefined {
-        const connectionState = this.connectionManager.currentConnectionState;
-        if (connectionState.tag === "connected") {
-            return connectionState.connectedAtlasCluster;
-        }
-
-        return undefined;
+        return this.connectionManager.currentConnectionState.connectedAtlasCluster;
     }
 }