CR comments

Author: nirinchev

src/tools/mongodb/metadata/connect.ts

@@ -42,7 +42,9 @@ export class ConnectTool extends MongoDBToolBase {
         ) {
             connectionString = connectionStringOrClusterName;
         } else {
-            // TODO:
+            // TODO: https://github.com/mongodb-js/mongodb-mcp-server/issues/19
+            // We don't support connecting via cluster name since we'd need to obtain the user credentials
+            // and fill in the connection string.
             return {
                 content: [
                     {

src/tools/mongodb/mongodbTool.ts

@@ -19,17 +19,15 @@ export abstract class MongoDBToolBase extends ToolBase {
     protected category: ToolCategory = "mongodb";
 
     protected async ensureConnected(): Promise<NodeDriverServiceProvider> {
-        let provider = this.session.serviceProvider;
-        if (!provider && config.connectionString) {
+        if (!this.session.serviceProvider && config.connectionString) {
             await this.connectToMongoDB(config.connectionString);
-            provider = this.session.serviceProvider;
         }
 
-        if (!provider) {
+        if (!this.session.serviceProvider) {
             throw new MongoDBError(ErrorCodes.NotConnectedToMongoDB, "Not connected to MongoDB");
         }
 
-        return provider;
+        return this.session.serviceProvider;
     }
 
     protected handleError(error: unknown): Promise<CallToolResult> | CallToolResult {