chore(NODE-4321): add typescript to eslint rules (#3304)

nbbeeken · web-flow · commit f92895fa4585 · 2022-06-30T13:16:25.000-04:00
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -181,6 +181,29 @@
         "typescript-eslint/ban-ts-comment": "off"
       }
     },
+    {
+      // Settings for typescript test files
+      "files": [
+        "src/**/*.ts"
+      ],
+      "parser": "@typescript-eslint/parser",
+      "parserOptions": {
+        "project": ["./tsconfig.json"]
+      },
+      "extends": [
+        "plugin:@typescript-eslint/recommended-requiring-type-checking"
+      ],
+      "rules": {
+        "@typescript-eslint/no-unsafe-member-access": "off",
+        "@typescript-eslint/no-unsafe-argument": "off",
+        "@typescript-eslint/no-unsafe-assignment": "off",
+        "@typescript-eslint/no-unsafe-return": "off",
+        "@typescript-eslint/no-unsafe-call": "off",
+
+        "@typescript-eslint/restrict-plus-operands": "off",
+        "@typescript-eslint/restrict-template-expressions": "off"
+      }
+    },
     {
       // Settings for typescript type test files
       "files": [
diff --git a/src/change_stream.ts b/src/change_stream.ts
@@ -894,7 +894,7 @@ export class ChangeStream<
 
     if (isResumableError(changeStreamError, this.cursor.maxWireVersion)) {
       this._endStream();
-      this.cursor.close();
+      this.cursor.close().catch(() => null);
 
       const topology = getTopology(this.parent);
       topology.selectServer(this.cursor.readPreference, {}, serverSelectionError => {
@@ -913,6 +913,7 @@ export class ChangeStream<
    *
    * we promisify _processErrorIteratorModeCallback until we have a promisifed version of selectServer.
    */
+  // eslint-disable-next-line @typescript-eslint/unbound-method
   private _processErrorIteratorMode = promisify(this._processErrorIteratorModeCallback);
 
   /** @internal */
@@ -923,7 +924,7 @@ export class ChangeStream<
     }
 
     if (isResumableError(changeStreamError, this.cursor.maxWireVersion)) {
-      this.cursor.close();
+      this.cursor.close().catch(() => null);
 
       const topology = getTopology(this.parent);
       topology.selectServer(this.cursor.readPreference, {}, serverSelectionError => {
diff --git a/src/cmap/command_monitoring_events.ts b/src/cmap/command_monitoring_events.ts
@@ -248,9 +248,8 @@ function extractCommand(command: WriteProtocolMessageType): Document {
     });
 
     OP_QUERY_KEYS.forEach(key => {
-      const opKey = key as typeof OP_QUERY_KEYS[number];
-      if (command[opKey]) {
-        result[opKey] = command[opKey];
+      if (command[key]) {
+        result[key] = command[key];
       }
     });
 
diff --git a/src/cmap/connect.ts b/src/cmap/connect.ts
@@ -8,7 +8,6 @@ import type { Document } from '../bson';
 import { Int32 } from '../bson';
 import { LEGACY_HELLO_COMMAND } from '../constants';
 import {
-  AnyError,
   MongoCompatibilityError,
   MongoError,
   MongoErrorLabel,
@@ -462,40 +461,36 @@ function makeSocks5Connection(options: MakeConnectionOptions, callback: Callback
       }
 
       // Then, establish the Socks5 proxy connection:
-      SocksClient.createConnection(
-        {
-          existing_socket: rawSocket,
-          timeout: options.connectTimeoutMS,
-          command: 'connect',
-          destination: {
-            host: destination.host,
-            port: destination.port
-          },
-          proxy: {
-            // host and port are ignored because we pass existing_socket
-            host: 'iLoveJavaScript',
-            port: 0,
-            type: 5,
-            userId: options.proxyUsername || undefined,
-            password: options.proxyPassword || undefined
-          }
+      SocksClient.createConnection({
+        existing_socket: rawSocket,
+        timeout: options.connectTimeoutMS,
+        command: 'connect',
+        destination: {
+          host: destination.host,
+          port: destination.port
         },
-        (err: AnyError, info: { socket: Stream }) => {
-          if (err) {
-            return callback(connectionFailureError('error', err));
-          }
-
+        proxy: {
+          // host and port are ignored because we pass existing_socket
+          host: 'iLoveJavaScript',
+          port: 0,
+          type: 5,
+          userId: options.proxyUsername || undefined,
+          password: options.proxyPassword || undefined
+        }
+      }).then(
+        ({ socket }) => {
           // Finally, now treat the resulting duplex stream as the
           // socket over which we send and receive wire protocol messages:
           makeConnection(
             {
               ...options,
-              existingSocket: info.socket,
+              existingSocket: socket,
               proxyHost: undefined
             },
             callback
           );
-        }
+        },
+        error => callback(connectionFailureError('error', error))
       );
     }
   );
diff --git a/src/cmap/connection.ts b/src/cmap/connection.ts
@@ -533,7 +533,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {
         clusterTime = session.clusterTime;
       }
 
-      const err = applySession(session, finalCmd, options as CommandOptions);
+      const err = applySession(session, finalCmd, options);
       if (err) {
         return callback(err);
       }
diff --git a/src/cmap/wire_protocol/compression.ts b/src/cmap/wire_protocol/compression.ts
@@ -52,9 +52,10 @@ export function compress(
       if (Snappy[PKG_VERSION].major <= 6) {
         Snappy.compress(dataToBeCompressed, callback);
       } else {
-        Snappy.compress(dataToBeCompressed)
-          .then(buffer => callback(undefined, buffer))
-          .catch(error => callback(error));
+        Snappy.compress(dataToBeCompressed).then(
+          buffer => callback(undefined, buffer),
+          error => callback(error)
+        );
       }
       break;
     }
@@ -102,9 +103,10 @@ export function decompress(
       if (Snappy[PKG_VERSION].major <= 6) {
         Snappy.uncompress(compressedData, { asBuffer: true }, callback);
       } else {
-        Snappy.uncompress(compressedData, { asBuffer: true })
-          .then(buffer => callback(undefined, buffer))
-          .catch(error => callback(error));
+        Snappy.uncompress(compressedData, { asBuffer: true }).then(
+          buffer => callback(undefined, buffer),
+          error => callback(error)
+        );
       }
       break;
     }
diff --git a/src/collection.ts b/src/collection.ts
@@ -725,7 +725,7 @@ export class Collection<TSchema extends Document = Document> {
     }
 
     if (typeof filter === 'function') {
-      callback = filter as Callback<WithId<TSchema> | null>;
+      callback = filter;
       filter = {};
       options = {};
     }
@@ -1128,7 +1128,7 @@ export class Collection<TSchema extends Document = Document> {
       this.s.db.s.client,
       new CountDocumentsOperation(
         this as TODO_NODE_3286,
-        filter as Document,
+        filter,
         resolveOptions(this, options as CountDocumentsOptions)
       ),
       callback
@@ -1191,7 +1191,7 @@ export class Collection<TSchema extends Document = Document> {
     callback?: Callback<any[]>
   ): Promise<any[]> | void {
     if (typeof filter === 'function') {
-      (callback = filter as Callback<any[]>), (filter = {}), (options = {});
+      (callback = filter), (filter = {}), (options = {});
     } else {
       if (arguments.length === 3 && typeof options === 'function') {
         (callback = options), (options = {});
@@ -1681,7 +1681,7 @@ export class Collection<TSchema extends Document = Document> {
     callback?: Callback<number>
   ): Promise<number> | void {
     if (typeof filter === 'function') {
-      (callback = filter as Callback<number>), (filter = {}), (options = {});
+      (callback = filter), (filter = {}), (options = {});
     } else {
       if (typeof options === 'function') (callback = options), (options = {});
     }
diff --git a/src/cursor/abstract_cursor.ts b/src/cursor/abstract_cursor.ts
@@ -67,7 +67,7 @@ export interface CursorCloseOptions {
 /** @public */
 export interface CursorStreamOptions {
   /** A transformation method applied to each document emitted by the stream */
-  transform?(doc: Document): Document;
+  transform?(this: void, doc: Document): Document;
 }
 
 /** @public */
@@ -597,7 +597,7 @@ export abstract class AbstractCursor<
       // We only want to end this session if we created it, and it hasn't ended yet
       if (session.explicit === false) {
         if (!session.hasEnded) {
-          session.endSession(() => null);
+          session.endSession().catch(() => null);
         }
         this[kSession] = this.client.startSession({ owner: this, explicit: false });
       }
@@ -883,7 +883,7 @@ class ReadableCursorStream extends Readable {
         //       a client during iteration. Alternatively, we could do the "right" thing and
         //       propagate the error message by removing this special case.
         if (err.message.match(/server is closed/)) {
-          this._cursor.close();
+          this._cursor.close().catch(() => null);
           return this.push(null);
         }
 
@@ -902,7 +902,7 @@ class ReadableCursorStream extends Readable {
       if (result == null) {
         this.push(null);
       } else if (this.destroyed) {
-        this._cursor.close();
+        this._cursor.close().catch(() => null);
       } else {
         if (this.push(result)) {
           return this._readNext();
diff --git a/src/deps.ts b/src/deps.ts
@@ -35,13 +35,12 @@ try {
 } catch {} // eslint-disable-line
 
 export interface KerberosClient {
-  step: (challenge: string, callback?: Callback<string>) => Promise<string> | void;
-  wrap: (
-    challenge: string,
-    options?: { user: string },
-    callback?: Callback<string>
-  ) => Promise<string> | void;
-  unwrap: (challenge: string, callback?: Callback<string>) => Promise<string> | void;
+  step(challenge: string): Promise<string>;
+  step(challenge: string, callback: Callback<string>): void;
+  wrap(challenge: string, options: { user: string }): Promise<string>;
+  wrap(challenge: string, options: { user: string }, callback: Callback<string>): void;
+  unwrap(challenge: string): Promise<string>;
+  unwrap(challenge: string, callback: Callback<string>): void;
 }
 
 type ZStandardLib = {
@@ -80,11 +79,7 @@ type SnappyLib = {
    * @param callback - ONLY USED IN SNAPPY 6.x
    */
   compress(buf: Buffer): Promise<Buffer>;
-  compress(buf: Buffer, callback: (error?: Error, buffer?: Buffer) => void): Promise<Buffer> | void;
-  compress(
-    buf: Buffer,
-    callback?: (error?: Error, buffer?: Buffer) => void
-  ): Promise<Buffer> | void;
+  compress(buf: Buffer, callback: (error?: Error, buffer?: Buffer) => void): void;
 
   /**
    * - Snappy 6.x takes a callback and returns void
@@ -99,12 +94,7 @@ type SnappyLib = {
     buf: Buffer,
     opt: { asBuffer: true },
     callback: (error?: Error, buffer?: Buffer) => void
-  ): Promise<Buffer> | void;
-  uncompress(
-    buf: Buffer,
-    opt: { asBuffer: true },
-    callback?: (error?: Error, buffer?: Buffer) => void
-  ): Promise<Buffer> | void;
+  ): void;
 };
 
 export let Snappy: SnappyLib | { kModuleError: MongoMissingDependencyError } = makeErrorModule(
@@ -141,6 +131,7 @@ interface AWS4 {
    * @param credentials - AWS credential details, sessionToken should be omitted entirely if its false-y
    */
   sign(
+    this: void,
     options: {
       path: '/';
       body: string;
diff --git a/src/mongo_client.ts b/src/mongo_client.ts
@@ -493,7 +493,6 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> {
               { endSessions },
               { readPreference: ReadPreference.primaryPreferred, noResponse: true }
             )
-            .then(() => null) // outcome does not matter
             .catch(() => null); // outcome does not matter
         })
         .then(() => {
@@ -638,7 +637,9 @@ export class MongoClient extends TypedEventEmitter<MongoClientEvents> {
       .then(() => {
         // Do not return the result of callback
       })
-      .finally(() => session.endSession());
+      .finally(() => {
+        session.endSession().catch(() => null);
+      });
   }
 
   /**
diff --git a/src/operations/common_functions.ts b/src/operations/common_functions.ts
@@ -34,7 +34,7 @@ export function indexInformation(
   let options = _optionsOrCallback as IndexInformationOptions;
   let callback = _callback as Callback;
   if ('function' === typeof _optionsOrCallback) {
-    callback = _optionsOrCallback as Callback;
+    callback = _optionsOrCallback;
     options = {};
   }
   // If we specified full information
diff --git a/src/operations/execute_operation.ts b/src/operations/execute_operation.ts
@@ -144,8 +144,9 @@ export function executeOperation<
       });
     } catch (error) {
       if (session?.owner != null && session.owner === owner) {
-        session.endSession();
+        session.endSession().catch(() => null);
       }
+
       throw error;
     }
   });
diff --git a/src/read_preference.ts b/src/read_preference.ts
@@ -163,14 +163,10 @@ export class ReadPreference {
     } else if (!(readPreference instanceof ReadPreference) && typeof readPreference === 'object') {
       const mode = readPreference.mode || readPreference.preference;
       if (mode && typeof mode === 'string') {
-        return new ReadPreference(
-          mode as ReadPreferenceMode,
-          readPreference.tags ?? readPreferenceTags,
-          {
-            maxStalenessSeconds: readPreference.maxStalenessSeconds,
-            hedge: options.hedge
-          }
-        );
+        return new ReadPreference(mode, readPreference.tags ?? readPreferenceTags, {
+          maxStalenessSeconds: readPreference.maxStalenessSeconds,
+          hedge: options.hedge
+        });
       }
     }
 
@@ -193,7 +189,7 @@ export class ReadPreference {
     } else if (r && !(r instanceof ReadPreference) && typeof r === 'object') {
       const mode = r.mode || r.preference;
       if (mode && typeof mode === 'string') {
-        options.readPreference = new ReadPreference(mode as ReadPreferenceMode, r.tags, {
+        options.readPreference = new ReadPreference(mode, r.tags, {
           maxStalenessSeconds: r.maxStalenessSeconds
         });
       }
diff --git a/src/sessions.ts b/src/sessions.ts
@@ -616,7 +616,7 @@ function attemptTransaction<TSchema>(
   }
 
   if (!isPromiseLike(promise)) {
-    session.abortTransaction();
+    session.abortTransaction().catch(() => null);
     throw new MongoInvalidArgumentError(
       'Function provided to `withTransaction` must return a Promise'
     );
diff --git a/src/utils.ts b/src/utils.ts

Original file line number	Diff line number	Diff line change
`@@ -533,7 +533,7 @@ export class Connection extends TypedEventEmitter<ConnectionEvents> {`
`533`	`533`	`clusterTime = session.clusterTime;`
`534`	`534`	`}`
`535`	`535`
`536`		`- const err = applySession(session, finalCmd, options as CommandOptions);`
	`536`	`+ const err = applySession(session, finalCmd, options);`
`537`	`537`	`if (err) {`
`538`	`538`	`return callback(err);`
`539`	`539`	`}`