Skip to content

Commit 277238f

Browse files
Merge pull request #77 from mostafamaklad/v1.9
V1.9.0
2 parents 4ea8090 + 134d06d commit 277238f

File tree

6 files changed

+29
-10
lines changed

6 files changed

+29
-10
lines changed

CHANGELOG.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,22 @@
22

33
All Notable changes to `laravel-permission-mongodb` will be documented in this file.
44

5+
## 1.9.0 - 2018-09-14
6+
7+
### Fixed
8+
- Fix wrong BelongsTo relationship
9+
- Config cleanup
10+
- Fixes for Lumen 5.6 compatibility
11+
- Fix classes resolution to config values
12+
- Fix permissions via roles
13+
- Fixed detection of Lumen
14+
15+
### Added
16+
- Add scrutinizer code intelligence
17+
18+
### Changed
19+
- Loose typing definitions for BelongsToMany
20+
521
## 1.8.2 - 2018-08-14
622

723
### Changed

src/Exceptions/MakladException.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ class MakladException extends InvalidArgumentException
1818
* @param int $code
1919
* @param Throwable|null $previous
2020
*/
21-
public function __construct($message = '', $code = 0, Throwable $previous = null)
21+
public function __construct(string $message = null, int $code = 0, Throwable $previous = null)
2222
{
2323
parent::__construct($message, $code, $previous);
2424

src/Exceptions/UnauthorizedException.php

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,16 @@ class UnauthorizedException extends HttpException
1717
* UnauthorizedException constructor.
1818
*
1919
* @param $statusCode
20-
* @param null $message
20+
* @param string $message
2121
* @param array $requiredRoles
2222
* @param array $requiredPermissions
2323
*/
24-
public function __construct($statusCode, $message = null, $requiredRoles = [], $requiredPermissions = [])
25-
{
24+
public function __construct(
25+
$statusCode,
26+
string $message = null,
27+
array $requiredRoles = [],
28+
array $requiredPermissions = []
29+
) {
2630
parent::__construct($statusCode, $message);
2731

2832
if (\config('permission.log_registration_exception')) {

src/Exceptions/UnauthorizedPermission.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ class UnauthorizedPermission extends UnauthorizedException
1212
* UnauthorizedPermission constructor.
1313
*
1414
* @param $statusCode
15-
* @param null $message
15+
* @param string $message
1616
* @param array $requiredPermissions
1717
*/
18-
public function __construct($statusCode, $message = null, $requiredPermissions = [])
18+
public function __construct($statusCode, string $message = null, array $requiredPermissions = [])
1919
{
2020
parent::__construct($statusCode, $message, [], $requiredPermissions);
2121
}

src/Exceptions/UnauthorizedRole.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ class UnauthorizedRole extends UnauthorizedException
1212
* UnauthorizedPermission constructor.
1313
*
1414
* @param $statusCode
15-
* @param null $message
15+
* @param string $message
1616
* @param array $requiredRoles
1717
*/
18-
public function __construct($statusCode, $message = null, $requiredRoles = [])
18+
public function __construct($statusCode, string $message = null, array $requiredRoles = [])
1919
{
2020
parent::__construct($statusCode, $message, $requiredRoles);
2121
}

src/Traits/HasPermissions.php

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
use Maklad\Permission\Guard;
1212
use Maklad\Permission\Helpers;
1313
use Maklad\Permission\Models\Role;
14-
use Maklad\Permission\Models\PermissionRole;
1514
use Maklad\Permission\PermissionRegistrar;
1615

1716
/**
@@ -317,7 +316,7 @@ public function getDirectPermissions(): Collection
317316
* Scope the model query to certain permissions only.
318317
*
319318
* @param Builder $query
320-
* @param string|array|Permission|Collection $permissions
319+
* @param string|array|\Maklad\Permission\Contracts\PermissionInterface|Collection $permissions
321320
*
322321
* @return Builder
323322
*/

0 commit comments

Comments
 (0)