From b40f9079646b2f20462e50d3519706eb6addb765 Mon Sep 17 00:00:00 2001 From: Mansi Pandya Date: Fri, 30 May 2025 15:48:43 -0400 Subject: [PATCH 1/2] fix: Refactor execute method signature --- src/main/kotlin/com/mparticle/kits/RoktKit.kt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/main/kotlin/com/mparticle/kits/RoktKit.kt b/src/main/kotlin/com/mparticle/kits/RoktKit.kt index c1f4235..3a7cd83 100644 --- a/src/main/kotlin/com/mparticle/kits/RoktKit.kt +++ b/src/main/kotlin/com/mparticle/kits/RoktKit.kt @@ -38,7 +38,8 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen ctx: Context ): List { applicationContext = ctx.applicationContext - val roktTagId = settings[ROKT_ACCOUNT_ID] + // val roktTagId = settings[ROKT_ACCOUNT_ID] + val roktTagId = "2754655826098840951" if (KitUtils.isEmpty(roktTagId)) { throwOnKitCreateError(NO_ROKT_ACCOUNT_ID) } @@ -121,8 +122,8 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen @Suppress("UNCHECKED_CAST", "CAST_NEVER_SUCCEEDS") override fun execute( viewName: String, - attributes: Map?, - mpRoktEventCallback: MParticle.MpRoktEventCallback, + attributes: Map, + mpRoktEventCallback: MParticle.MpRoktEventCallback?, placeHolders: MutableMap>?, fontTypefaces: MutableMap>?, filterUser: FilteredMParticleUser? From 6e228045ec7779f78508ce8cb565625e0b035e9c Mon Sep 17 00:00:00 2001 From: Mansi Pandya Date: Fri, 30 May 2025 15:50:38 -0400 Subject: [PATCH 2/2] Removed hardcod Id --- src/main/kotlin/com/mparticle/kits/RoktKit.kt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/kotlin/com/mparticle/kits/RoktKit.kt b/src/main/kotlin/com/mparticle/kits/RoktKit.kt index 3a7cd83..79e710e 100644 --- a/src/main/kotlin/com/mparticle/kits/RoktKit.kt +++ b/src/main/kotlin/com/mparticle/kits/RoktKit.kt @@ -38,8 +38,7 @@ class RoktKit : KitIntegration(), CommerceListener, IdentityListener, RoktListen ctx: Context ): List { applicationContext = ctx.applicationContext - // val roktTagId = settings[ROKT_ACCOUNT_ID] - val roktTagId = "2754655826098840951" + val roktTagId = settings[ROKT_ACCOUNT_ID] if (KitUtils.isEmpty(roktTagId)) { throwOnKitCreateError(NO_ROKT_ACCOUNT_ID) }