chore: restore some eslint rules (#2011)

* feat: add github action to test a ts project and build it

* chore: restore no unused vars rule, except for fn params

* chore: restore import order and run lint-fix

* chore: remove unused rule

* chore: restore prefer-destructuring rule and run lint-fix

* chore: remove unused rules

* chore: remove ts test

* chore: restore import order for should

Author: DavideViolante

.eslintrc.js

@@ -22,28 +22,23 @@ module.exports = {
 	rules: {
 		'global-require': 'off',
 		'no-console': process.env.NODE_ENV === 'production' ? 'warn' : 'off',
-		'no-unused-vars': 'off',
+		'no-unused-vars': ['error', { args: 'none' }],
 		'no-underscore-dangle': 'off',
 		'no-param-reassign': 'off',
 		'no-restricted-syntax': 'off',
-		camelcase: 'off',
 		'default-case': 'off',
 		'consistent-return': 'off',
-		'import/order': 'off',
 		'max-classes-per-file': 'off',
 		'no-plusplus': 'off',
-		'guard-for-in': 'off',
 		'no-bitwise': 'off',
 		'class-methods-use-this': 'off',
 		'no-continue': 'off',
-		'prefer-destructuring': 'off',
-		'no-use-before-define': 'off',
 		// Typescript rules
-		'@typescript-eslint/interface-name-prefix': 'off',
-		'@typescript-eslint/explicit-function-return-type': 'off',
-		'@typescript-eslint/explicit-module-boundary-types': 'off',
 		'@typescript-eslint/no-explicit-any': 'off',
-		'@typescript-eslint/no-unused-vars': 'off',
+		'@typescript-eslint/no-unused-vars': [
+			'error',
+			{ args: 'none' }
+		],
 		'@typescript-eslint/naming-convention': 'off',
 		'@typescript-eslint/dot-notation': 'off',
 		'@typescript-eslint/no-use-before-define': 'off',

src/bin/mqtt.ts

@@ -13,7 +13,7 @@ import publish from './pub'
 import subscribe from './sub'
 
 // eslint-disable-next-line @typescript-eslint/no-var-requires
-const version = require('../../package.json').version
+const { version } = require('../../package.json')
 
 const helpMe = help({
 	dir: path.join(__dirname, '../../', 'help'),

src/bin/pub.ts

@@ -8,9 +8,9 @@ import help from 'help-me'
 
 import minimist, { type ParsedArgs } from 'minimist'
 import split2 from 'split2'
-import { connect } from '../mqtt'
 import { type IClientOptions, type IClientPublishOptions } from 'src/lib/client'
 import { pipeline } from 'stream'
+import { connect } from '../mqtt'
 
 const helpMe = help({
 	dir: path.join(__dirname, '../../', 'help'),

src/bin/sub.ts

@@ -4,8 +4,8 @@ import path from 'path'
 import fs from 'fs'
 import minimist from 'minimist'
 import help from 'help-me'
-import { connect } from '../mqtt'
 import { type IClientOptions } from 'src/lib/client'
+import { connect } from '../mqtt'
 
 const helpMe = help({
 	dir: path.join(__dirname, '../../', 'help'),

src/lib/client.ts

@@ -1,7 +1,6 @@
 /**
  * Module dependencies
  */
-import TopicAliasRecv from './topic-alias-recv'
 import mqttPacket, {
 	type IAuthPacket,
 	IConnackPacket,
@@ -15,17 +14,18 @@ import mqttPacket, {
 	type ISubackPacket,
 	type IConnectPacket,
 } from 'mqtt-packet'
-import DefaultMessageIdProvider, {
-	type IMessageIdProvider,
-} from './default-message-id-provider'
 import { type DuplexOptions, Writable } from 'readable-stream'
 import clone from 'rfdc/default'
-import * as validations from './validations'
 import _debug from 'debug'
-import Store, { type IStore } from './store'
-import handlePacket from './handlers'
 import type { ClientOptions } from 'ws'
 import { type ClientRequestArgs } from 'http'
+import * as validations from './validations'
+import Store, { type IStore } from './store'
+import handlePacket from './handlers'
+import DefaultMessageIdProvider, {
+	type IMessageIdProvider,
+} from './default-message-id-provider'
+import TopicAliasRecv from './topic-alias-recv'
 import {
 	type DoneCallback,
 	type ErrorWithReasonCode,
@@ -1157,7 +1157,7 @@ export default class MqttClient extends TypedEventEmitter<MqttClientEventCallbac
 		}
 		opts = { ...defaultOpts, ...opts } as IClientSubscribeOptions
 
-		const properties = opts.properties
+		const { properties } = opts
 
 		const subs: ISubscriptionRequest[] = []
 

src/lib/connect/index.ts

@@ -28,8 +28,9 @@ function parseAuthOptions(opts: IClientOptions) {
 	if (opts.auth) {
 		matches = opts.auth.match(/^(.+):(.+)$/)
 		if (matches) {
-			opts.username = matches[1]
-			opts.password = matches[2]
+			const [, username, password] = matches
+			opts.username = username
+			opts.password = password
 		} else {
 			opts.username = opts.auth
 		}

src/lib/connect/socks.ts

@@ -3,10 +3,10 @@ import { Duplex } from 'stream'
 import { SocksClient, type SocksProxy } from 'socks'
 import * as dns from 'dns'
 import { type SocksProxyType } from 'socks/typings/common/constants'
-import { type IStream } from '../shared'
 import { promisify } from 'util'
 import { type Socket } from 'net'
 import assert from 'assert'
+import { type IStream } from '../shared'
 
 const debug = _debug('mqttjs:socks')
 

src/lib/connect/tcp.ts

@@ -1,7 +1,6 @@
-import { type StreamBuilder } from '../shared'
-
 import net from 'net'
 import _debug from 'debug'
+import { type StreamBuilder } from '../shared'
 import openSocks from './socks'
 
 const debug = _debug('mqttjs:tcp')

src/lib/connect/ws.ts

@@ -1,8 +1,8 @@
-import { type StreamBuilder } from '../shared'
 import { Buffer } from 'buffer'
 import Ws, { type ClientOptions } from 'ws'
 import _debug from 'debug'
 import { type DuplexOptions, Transform } from 'readable-stream'
+import { type StreamBuilder } from '../shared'
 import isBrowser from '../is-browser'
 import { type IClientOptions } from '../client'
 import type MqttClient from '../client'

src/lib/connect/wx.ts

@@ -1,7 +1,6 @@
-import { type StreamBuilder } from '../shared'
-
 import { Buffer } from 'buffer'
 import { Transform } from 'readable-stream'
+import { type StreamBuilder } from '../shared'
 import { type IClientOptions } from '../client'
 import type MqttClient from '../client'
 import { BufferedDuplex } from '../BufferedDuplex'