Bugfix for 'SqliteForeignKeyIndexConvention'.

Author: msallin

SQLite.CodeFirst/Convention/SqliteForeignKeyIndexConvention.cs

@@ -44,28 +44,45 @@ public virtual void Apply(AssociationType item, DbModel model)
                     continue;
                 }
 
+                string tableName = item.Constraint.ToRole.GetEntityType().GetTableName();
+                string propertyName = edmProperty.Name;
+
                 // The original attribute is removed. The none-ForeignKeyIndicies will be remained and readded without any modification
                 // and the foreignKeyIncidies will be readded with the correct name.
                 edmProperty.RemoveAnnotation(IndexAnnotationName);
 
                 // The schema for the automatically generated index name is "IX_{TableName}_{PropertyName}"
-                var noneForeignKeyIndicies = annotation.Indexes.Where(index => index.Name != "IX_" + edmProperty.Name);
-                IndexAnnotation newIndexAnnotation = new IndexAnnotation(noneForeignKeyIndicies);
+                var noneForeignKeyIndicies = annotation.Indexes.Where(index => index.Name != "IX_" + propertyName);
+                var newIndexAnnotation = new IndexAnnotation(noneForeignKeyIndicies);
 
                 // The schema for a FK index, which is generated by the Entity Framework, is "IX_{PropertyName}"
-                var property = edmProperty;
-                var foreignKeyIndicies = annotation.Indexes.Where(index => index.Name == "IX_" + property.Name);
-                foreach (var foreignKeyIndex in foreignKeyIndicies)
+                var foreignKeyIndicies = annotation.Indexes.Where(index => index.Name == "IX_" + propertyName);
+                for (int i = 0; i < foreignKeyIndicies.Count(); i++)
                 {
-                    var indexAttribute = new IndexAttribute(String.Format(CultureInfo.InvariantCulture, "IX_{0}_{1}", item.Constraint.ToRole.GetEntityType().GetTableName(), edmProperty.Name));
-                    IndexAnnotation foreignKeyIndexAnnotation = new IndexAnnotation(indexAttribute);
+                    IndexAnnotation foreignKeyIndexAnnotation = CreateIndexAnnotation(tableName, propertyName, i);
                     newIndexAnnotation = (IndexAnnotation)newIndexAnnotation.MergeWith(foreignKeyIndexAnnotation);
                 }
 
                 edmProperty.AddAnnotation(IndexAnnotationName, newIndexAnnotation);
             }
         }
 
+        private static IndexAnnotation CreateIndexAnnotation(string tableName, string propertyName, int count)
+        {
+            var indexName = String.Format(CultureInfo.InvariantCulture, "IX_{0}_{1}", tableName, propertyName);
+
+            // If there are two Indicies on the same property, the count is added.
+            // In SQLite an Index name must be global unique.
+            // To be honest, it should never happen. But because its possible by using the API, it should be covered.
+            if (count > 0)
+            {
+                indexName = String.Format("{0}_{1}", indexName, count);
+            }
+
+            var indexAttribute = new IndexAttribute(indexName);
+            return new IndexAnnotation(indexAttribute);
+        }
+
         private static IndexAnnotation GetAnnotation(IEnumerable<MetadataProperty> metadataProperties, string name)
         {
             foreach (MetadataProperty metadataProperty in metadataProperties)