#139: Deleted unnecessary transaction creation.

Author: msallin

SQLite.CodeFirst/Public/DbInitializers/SqliteInitializerBase.cs

@@ -26,12 +26,7 @@ public abstract class SqliteInitializerBase<TContext> : IDatabaseInitializer<TCo
     {
         protected SqliteInitializerBase(DbModelBuilder modelBuilder)
         {
-            if (modelBuilder == null)
-            {
-                throw new ArgumentNullException("modelBuilder");
-            }
-
-            ModelBuilder = modelBuilder;
+            ModelBuilder = modelBuilder ?? throw new ArgumentNullException(nameof(modelBuilder));
 
             // This convention will crash the SQLite Provider before "InitializeDatabase" gets called.
             // See https://github.com/msallin/SQLiteCodeFirst/issues/7 for details.
@@ -76,35 +71,11 @@ public virtual void InitializeDatabase(TContext context)
             string dbFile = GetDatabasePathFromContext(context);
             InMemoryAwareFile.CreateDirectory(dbFile);
 
-            using (DbContextTransaction transaction = context.Database.BeginTransaction())
-            {
-                try
-                {
-                    var sqliteDatabaseCreator = new SqliteDatabaseCreator();
-                    sqliteDatabaseCreator.Create(context.Database, model);
-                    transaction.Commit();
-                }
-                catch (Exception)
-                {
-                    transaction.Rollback();
-                    throw;
-                }
-            }
+            var sqliteDatabaseCreator = new SqliteDatabaseCreator();
+            sqliteDatabaseCreator.Create(context.Database, model);
 
-            using (DbContextTransaction transaction = context.Database.BeginTransaction())
-            {
-                try
-                {
-                    Seed(context);
-                    context.SaveChanges();
-                    transaction.Commit();
-                }
-                catch (Exception)
-                {
-                    transaction.Rollback();
-                    throw;
-                }
-            }
+            Seed(context);
+            context.SaveChanges();
         }
 
         /// <summary>

SQLite.CodeFirst/Public/SqliteDatabaseCreator.cs

@@ -8,6 +8,11 @@ namespace SQLite.CodeFirst
     /// <summary>
     /// Creates a SQLite-Database based on a Entity Framework <see cref="Database"/> and <see cref="DbModel"/>.
     /// This creator can be used standalone or within an initializer.
+    /// <remark>
+    /// The generated DDL-SQL will be executed together as one statement.
+    /// If there is a open transaction on the Database, the statement will be executed within this transaction.
+    /// Otherwise it will be executed within a own transaction. In anyway the atomicity is guaranteed.
+    /// </remark>
     /// </summary>
     public class SqliteDatabaseCreator : IDatabaseCreator
     {