Fix NPE at ObjectMapper#copy with MessagePackFactory

Author: komamitsu

msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackFactory.java

@@ -58,7 +58,9 @@ public MessagePackFactory(MessagePackFactory src)
         this.packerConfig = src.packerConfig.clone();
         this.reuseResourceInGenerator = src.reuseResourceInGenerator;
         this.reuseResourceInParser = src.reuseResourceInParser;
-        this.extTypeCustomDesers = new ExtensionTypeCustomDeserializers(src.extTypeCustomDesers);
+        if (src.extTypeCustomDesers != null) {
+            this.extTypeCustomDesers = new ExtensionTypeCustomDeserializers(src.extTypeCustomDesers);
+        }
     }
 
     public MessagePackFactory setReuseResourceInGenerator(boolean reuseResourceInGenerator)

msgpack-jackson/src/test/java/org/msgpack/jackson/dataformat/MessagePackFactoryTest.java

@@ -22,6 +22,7 @@
 import com.fasterxml.jackson.core.type.TypeReference;
 import com.fasterxml.jackson.databind.AnnotationIntrospector;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import com.fasterxml.jackson.databind.introspect.JacksonAnnotationIntrospector;
 import org.junit.Test;
 import org.msgpack.core.MessagePack;
 
@@ -58,7 +59,36 @@ public void testCreateParser()
     }
 
     @Test
-    public void copy()
+    public void copyWithDefaultConfig()
+            throws IOException
+    {
+        MessagePackFactory messagePackFactory = new MessagePackFactory();
+        ObjectMapper copiedObjectMapper = new ObjectMapper(messagePackFactory).copy();
+        JsonFactory copiedFactory = copiedObjectMapper.getFactory();
+        assertThat(copiedFactory, is(instanceOf(MessagePackFactory.class)));
+        MessagePackFactory copiedMessagePackFactory = (MessagePackFactory) copiedFactory;
+
+        assertThat(copiedMessagePackFactory.getPackerConfig().isStr8FormatSupport(), is(true));
+
+        assertThat(copiedMessagePackFactory.getExtTypeCustomDesers(), is(nullValue()));
+
+        assertThat(copiedMessagePackFactory.isEnabled(JsonGenerator.Feature.AUTO_CLOSE_TARGET), is(true));
+        assertThat(copiedMessagePackFactory.isEnabled(JsonParser.Feature.AUTO_CLOSE_SOURCE), is(true));
+
+        Collection<AnnotationIntrospector> annotationIntrospectors = copiedObjectMapper.getSerializationConfig().getAnnotationIntrospector().allIntrospectors();
+        assertThat(annotationIntrospectors.size(), is(1));
+        assertThat(annotationIntrospectors.stream().findFirst().get(), is(instanceOf(JacksonAnnotationIntrospector.class)));
+
+        HashMap<String, Integer> map = new HashMap<>();
+        map.put("one", 1);
+        Map<String, Integer> deserialized = copiedObjectMapper
+            .readValue(objectMapper.writeValueAsBytes(map), new TypeReference<Map<String, Integer>>() {});
+        assertThat(deserialized.size(), is(1));
+        assertThat(deserialized.get("one"), is(1));
+    }
+
+    @Test
+    public void copyWithAdvancedConfig()
             throws IOException
     {
         ExtensionTypeCustomDeserializers extTypeCustomDesers = new ExtensionTypeCustomDeserializers();