Skip to content

Commit a66fc2e

Browse files
committed
Address feedback from @komamitsu
1 parent 8247f24 commit a66fc2e

File tree

1 file changed

+4
-19
lines changed

1 file changed

+4
-19
lines changed

msgpack-jackson/src/main/java/org/msgpack/jackson/dataformat/MessagePackGenerator.java

Lines changed: 4 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -186,33 +186,18 @@ else if (value instanceof NodeArray) {
186186

187187
// This is an internal constructor for nested serialization.
188188
private MessagePackGenerator(
189-
int features,
190-
ObjectCodec codec,
191-
OutputStream out,
192-
MessagePack.PackerConfig packerConfig)
193-
{
194-
super(features, codec);
195-
this.output = out;
196-
this.messagePacker = packerConfig.newPacker(out);
197-
this.packerConfig = packerConfig;
198-
this.nodes = new ArrayList<>();
199-
this.writeIntegerKeysAsStringKeys = true;
200-
}
201-
202-
public MessagePackGenerator(
203189
int features,
204190
ObjectCodec codec,
205191
OutputStream out,
206192
MessagePack.PackerConfig packerConfig,
207-
boolean reuseResourceInGenerator)
208-
throws IOException
193+
boolean writeIntegerKeysAsStringKeys)
209194
{
210195
super(features, codec);
211196
this.output = out;
212-
this.messagePacker = packerConfig.newPacker(getMessageBufferOutputForOutputStream(out, reuseResourceInGenerator));
197+
this.messagePacker = packerConfig.newPacker(out);
213198
this.packerConfig = packerConfig;
214199
this.nodes = new ArrayList<>();
215-
this.writeIntegerKeysAsStringKeys = true;
200+
this.writeIntegerKeysAsStringKeys = writeIntegerKeysAsStringKeys;
216201
}
217202

218203
public MessagePackGenerator(
@@ -393,7 +378,7 @@ else if (v instanceof MessagePackExtensionType) {
393378
else {
394379
messagePacker.flush();
395380
ByteArrayOutputStream outputStream = new ByteArrayOutputStream();
396-
MessagePackGenerator messagePackGenerator = new MessagePackGenerator(getFeatureMask(), getCodec(), outputStream, packerConfig);
381+
MessagePackGenerator messagePackGenerator = new MessagePackGenerator(getFeatureMask(), getCodec(), outputStream, packerConfig, writeIntegerKeysAsStringKeys);
397382
getCodec().writeValue(messagePackGenerator, v);
398383
output.write(outputStream.toByteArray());
399384
}

0 commit comments

Comments
 (0)