Merge pull request #66 from msgpack/fix_range_error_on_encoding_blob

fix RangeError in encoding BLOB

Author: gfx

src/Encoder.ts

@@ -80,7 +80,8 @@ export class Encoder {
           this.writeU8(object);
         } else if (object < 0x100) {
           // uint 8
-          this.writeU8v(0xcc, object);
+          this.writeU8(0xcc);
+          this.writeU8(object);
         } else if (object < 0x10000) {
           // uint 16
           this.writeU8(0xcd);
@@ -200,7 +201,7 @@ export class Encoder {
       throw new Error(`Too large binary: ${size}`);
     }
     const bytes = ensureUint8Array(object);
-    this.writeU8v(...bytes);
+    this.writeU8a(bytes);
   }
 
   encodeArray(object: Array<unknown>, depth: number) {
@@ -285,7 +286,7 @@ export class Encoder {
       throw new Error(`Too large extension object: ${size}`);
     }
     this.writeI8(ext.type);
-    this.writeU8v(...ext.data);
+    this.writeU8a(ext.data);
   }
 
   writeU8(value: number) {
@@ -295,14 +296,11 @@ export class Encoder {
     this.pos++;
   }
 
-  writeU8v(...values: Array<number>) {
+  writeU8a(values: ArrayLike<number>) {
     const size = values.length;
     this.ensureBufferSizeToWrite(size);
 
-    const pos = this.pos;
-    for (let i = 0; i < size; i++) {
-      this.view.setUint8(pos + i, values[i]);
-    }
+    this.bytes.set(values, this.pos);
     this.pos += size;
   }
 

test/msgpack-test-suite.test.ts

@@ -96,7 +96,8 @@ describe("msgpack-test-suite", () => {
       STR_INCLUDING_NUL: "foo\0bar\0",
       STR_BROKEN_FF: "\xff",
       BIN16: new Uint8Array(0x100).fill(0xff),
-      BIN32: new Uint8Array(0x10000).fill(0xff),
+      BIN32: new Uint8Array(0x10_000).fill(0xff),
+      BIN32LARGE: new Uint8Array(0x100_000).fill(0xff), // regression: caused "RangeError: Maximum call stack size exceeded"
       ARRAY16: new Array<boolean>(0x100).fill(true),
       ARRAY32: new Array<boolean>(0x10000).fill(true),
       MAP16: new Array<null>(0x100).fill(null).reduce<Record<string, number>>((acc, _val, i) => {