fix: Error diagnostics must not be marked as "OK"

Author: david-rodrigues

src/Diagnostic.ts

@@ -272,6 +272,10 @@ export const generatePackagesDiagnostics = async (
               packageDiagnostic
             )
           }
+
+          if (packageDiagnostic.severity === DiagnosticSeverity.Error) {
+            return documentDecorations?.clearLine(packageInfo.getLine())
+          }
         }
 
         documentDecorations?.setCheckedMessage(packageInfo.getLine())

src/DocumentDecoration.ts

@@ -158,6 +158,14 @@ export class DocumentDecoration {
     this.render()
   }
 
+  public clearLine(line: number): void {
+    DocumentDecorationManager.fromDocument(this.document).layers.forEach(
+      (decoration) => decoration.lines.delete(line)
+    )
+
+    this.render()
+  }
+
   public setCheckedMessage(line: number): void {
     this.setLine(line, [
       new Message(

src/extension.test.ts

@@ -277,7 +277,7 @@ describe("package diagnostics", () => {
     })
 
     expect(diagnostics[0]?.message).toContain("Invalid package version")
-    expect(decorations[0]).toStrictEqual([Icons.CHECKED])
+    expect(decorations).toStrictEqual([])
   })
 
   it("decorations disabled", async () => {
@@ -617,7 +617,7 @@ describe("code coverage", () => {
     )?.[1](document)
 
     expect(diagnostics).toHaveLength(1)
-    expect(decorations[0]).toStrictEqual([Icons.CHECKED])
+    expect(decorations).toStrictEqual([])
   })
 
   it("decoration re-flush layers", async () => {