refactor: Improved the text of new packages to be installed

Author: david-rodrigues

locales/bundle.l10n.jsonc

@@ -28,7 +28,7 @@
   "Package \"{0}\" pending installation: {1}.": "", // The package has been declared as a dependency, but no version has yet been installed.
   "Newer version of \"{0}\" is available: {1}.": "", // New version available which can be used by user.
   "Pre-release version of \"{0}\".": "", // The defined user version is a pre-release, and there is no better alternative yet.
-  "Ready-to-install package. Just run your package manager install command.": "", // User must run the `npm install` to install new packages based on version defined.
+  "Ready-to-install package \"{0}\" at version {1}. Just run your package manager install command.": "", // User must run the `npm install` to install new packages based on version defined.
   "Security advisory: this package version has a known flaw level {0}/{1}.": "", // Diagnostic warning when a security advisory exists.
   "Please upgrade to version {0} or higher.": "", // Suggested upgrade to a version above.
   "No fix available yet.": "", // The flaw is not yet known to be resolved in a future release.
@@ -38,7 +38,6 @@
   "Install packages": "", //  Forces the display of the notification suggesting to update the package (two or more packages to be installed).
 
   // DocumentDecoration.ts related.
-  "Install pending": "", // The package was never installed, but the version entered by the user is the latest available.
   "Update available:": "", // The package has already been installed and has a new version available.
   "Latest version:": "", // The package was never installed, and the user's version is not the latest available.
   "install pending": "", // The informed version has not yet been installed by the user.

locales/bundle.l10n.pt-br.json

@@ -19,7 +19,7 @@
   "Package \"{0}\" pending installation: {1}.": "Dependência \"{0}\" com instalação pendente: {1}",
   "Newer version of \"{0}\" is available: {1}.": "Versão mais nova disponível para a dependência \"{0}\": {1}",
   "Pre-release version of \"{0}\".": "Versão pre-release de \"{0}\".",
-  "Ready-to-install package. Just run your package manager install command.": "Pacote pronto para instalar. Basta executar o comando `install` do seu gerenciador de dependências.",
+  "Ready-to-install package \"{0}\" at version {1}. Just run your package manager install command.": "Pacote pronto para instalar. Basta executar o comando `install` do seu gerenciador de dependências.",
   "Security advisory: this package version has a known flaw level {0}/{1}.": "",
   "Please upgrade to version {0} or higher.": "Por favor, atualize para a versão {0} ou superior.",
   "No fix available yet.": "Ainda não há uma correção disponível.",
@@ -28,7 +28,6 @@
   "Install package": "Instalar dependência",
   "Install packages": "Instalar dependências",
 
-  "Install pending": "Instalação pendente",
   "Update available:": "Atualização disponível:",
   "Latest version:": "Versão mais recente:",
   "install pending": "instalação pendente",

src/Diagnostic.ts

@@ -164,29 +164,16 @@ export const getPackageDiagnostic = async (
     )
   }
 
-  if (!(await packageInfo.isInstalled())) {
-    return new PackageRelatedDiagnostic(
-      packageInfo.versionRange,
-      l10n.t(
-        'Package "{0}" pending installation: {1}.',
-        packageInfo.name,
-        versionLatest
-      ),
-      DiagnosticSeverity.Information,
-      document,
-      packageInfo,
-      DiagnosticType.READY_TO_INSTALL
-    )
-  }
-
   if (!(await packageInfo.isVersionUpdatable())) {
     // The user has the latest version defined in `package.json`,
     // but still needs to run `npm install` to complete.
     if (await packageInfo.requiresInstallCommand()) {
       return new PackageRelatedDiagnostic(
         packageInfo.versionRange,
         l10n.t(
-          "Ready-to-install package. Just run your package manager install command."
+          'Ready-to-install package "{0}" at version {1}. Just run your package manager install command.',
+          packageInfo.name,
+          versionLatest
         ),
         DiagnosticSeverity.Information,
         document,

src/DocumentDecoration.ts

@@ -208,22 +208,6 @@ export class DocumentDecoration {
     const packageVersionInstalled =
       await packageInfo.packageRelated.getVersionInstalled()
 
-    // It informs that the version has not yet been installed,
-    // but the user's version is in fact the last one available.
-    if (
-      !packageVersionInstalled &&
-      (await packageInfo.packageRelated.isVersionMaxed())
-    ) {
-      return this.setLine(line, [
-        new Message(
-          Icons.PENDING,
-          ThemeLight.ICON_AVAILABLE,
-          ThemeDark.ICON_AVAILABLE
-        ),
-        new Message(l10n.t("Install pending")),
-      ])
-    }
-
     if (await packageInfo.packageRelated.requiresInstallCommand()) {
       return this.setLine(line, [
         new Message(

src/PackageInfo.ts

@@ -44,20 +44,6 @@ export class PackageInfo {
     return this.versionRange.end.line
   }
 
-  // Check if the package is installed.
-  public async isInstalled(): Promise<boolean> {
-    const packagesInstalled = await getPackagesInstalled()
-
-    if (!packagesInstalled) {
-      return false
-    }
-
-    return (
-      this.name in packagesInstalled &&
-      packagesInstalled[this.name] !== undefined
-    )
-  }
-
   // Check if is a valid package name.
   // Eg. "typescript" instead of "type script".
   public isNameValid(): boolean {
@@ -129,7 +115,11 @@ export class PackageInfo {
     }
 
     const versionLatest = (await this.getVersionLatest())!
-    const versionNormalized = this.getVersionNormalized()!
+    const versionNormalized = this.getVersionNormalized()
+
+    if (!versionNormalized) {
+      return true
+    }
 
     // Check if the version difference is compatible with what was configured by the user.
     // If the difference is less than the minimum configured then there is no need for a diagnostic.

src/extension.test.ts

@@ -42,9 +42,11 @@ describe("package diagnostics", () => {
       selectFirsts: 1,
     })
 
-    expect(diagnostics[0]?.message).toContain("pending installation")
+    expect(diagnostics[0]?.message).toContain("run your package manager")
     expect(diagnostics[0]?.severity).toBe(DiagnosticSeverity.Information)
-    expect(decorations[0]).toContain("Install pending")
+    expect(decorations[0]).toContain(
+      "Now run your package manager install command."
+    )
     expect(actions[0]?.title).toBe("Install package")
     expect(actions).toHaveLength(1)
   })
@@ -268,7 +270,9 @@ describe("package diagnostics", () => {
       packagesRepository: { "npm-outdated": ["1.0.0", "1.0.1"] },
     })
 
-    expect(diagnostics[0]?.message).toContain("run your package manager")
+    expect(diagnostics[0]?.message).toBe(
+      'Ready-to-install package "npm-outdated" at version 1.0.1. Just run your package manager install command.'
+    )
     expect(decorations[0]).toContain(
       "Now run your package manager install command."
     )
@@ -312,6 +316,15 @@ describe("package diagnostics", () => {
     expect(decorations).toStrictEqual([])
   })
 
+  it("dependency version is incomplete/empty", async () => {
+    const { decorations } = await vscodeSimulator({
+      packageJson: { dependencies: { "npm-outdated": "" } },
+      packagesRepository: { "npm-outdated": ["1.0.0"] },
+    })
+
+    expect(decorations[0]).toContain("(install pending)")
+  })
+
   it("decorations simple", async () => {
     const { decorations } = await vscodeSimulator({
       configurations: { decorations: "simple" },